Fix & improve ON UPDATE trigger behavior
#156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etion Previously, the triger was deleted for all column operations. That was not really correct, as a side effect of some non-altering operations (e.g, SET/DROP DEFAULT), would then be removing the trigger. Additionally, since CHANGE statement handling use continue/break, the trigger creation was skipped. This commit fixes that and adds a test case for that scenario.
This doesn't change the outcomes as the keyword was skipped by the loop itself, but it is more correct and consistent to skip those two tokens.
brandonpayton
approved these changes
Aug 16, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just fixes and improves #150.
With some further testing, I realized there were some issues in my original implementation:
ON UPDATEtrigger usesidinstead ofrowid. This is a regression — a query can fail now for anyone who usesON UPDATEand doesn't have anidcolumn. I somehow missed that 🤦♂️CHANGEs, and it is actually missed by theCHANGEfor creation as well, as that branch usescontinue/breakand skips the trigger creation below.I fixed both and added test coverage.