Merge pull request #1125 from Automattic/fix/domain-management-cname-…

…display Domains: DNS: Fix bug with CNAME display after adding domain
Automattic · Dec 2, 2015 · 8f20724 · 8f20724
2 parents 774c0bd + 9a52c6a
commit 8f20724
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 12 deletions.
diff --git a/client/lib/domains/dns/index.js b/client/lib/domains/dns/index.js
@@ -2,25 +2,28 @@
  * External dependencies
  */
 const includes = require( 'lodash/collection/includes' ),
-	mapValues = require( 'lodash/object/mapValues' );
+	mapValues = require( 'lodash/object/mapValues' ),
+	endsWith = require( 'lodash/string/endsWith' );
 
-function validateAllFields( fieldValues ) {
+function validateAllFields( fieldValues, selectedDomainName ) {
 	return mapValues( fieldValues, ( value, fieldName ) => {
 		const isValid = validateField( {
 			name: fieldName,
 			value: value,
-			type: fieldValues.type
+			type: fieldValues.type,
+			selectedDomainName
 		} );
 
 		return isValid ? [] : [ 'Invalid' ];
 	} );
 }
 
-function validateField( { name, value, type } ) {
+function validateField( { name, value, type, selectedDomainName } ) {
 	switch ( name ) {
 		case 'name':
+			return isValidName( value, type, selectedDomainName );
 		case 'target':
-			return isValidName( value );
+			return isValidDomainName( value );
 		case 'data':
 			return isValidData( value, type );
 		case 'protocol':
@@ -36,10 +39,29 @@ function validateField( { name, value, type } ) {
 	}
 }
 
-function isValidName( name ) {
+function isValidDomainName( name ) {
 	return /^([\da-z-]+\.)+[\da-z-]+$/i.test( name );
 }
 
+function isValidName( name, type, selectedDomainName ) {
+	switch ( type ) {
+		case 'CNAME':
+			return (
+				isValidCname( name, selectedDomainName ) &&
+				isValidDomainName( name )
+			);
+		default:
+			return isValidDomainName( name );
+	}
+}
+
+function isValidCname( name, selectedDomainName ) {
+	return (
+		name !== selectedDomainName &&
+		endsWith( name, selectedDomainName )
+	);
+}
+
 function isValidData( data, type ) {
 	switch ( type ) {
 		case 'A':
@@ -48,7 +70,7 @@ function isValidData( data, type ) {
 			return data.match( /^[a-f0-9\:]+$/i );
 		case 'CNAME':
 		case 'MX':
-			return isValidName( data );
+			return isValidDomainName( data );
 		case 'TXT':
 			return data.length < 256;
 	}

diff --git a/client/lib/domains/dns/reducer.js b/client/lib/domains/dns/reducer.js
@@ -3,6 +3,7 @@
  */
 import filter from 'lodash/collection/filter';
 import React from 'react/addons';
+import escapeRegExp from 'lodash/string/escapeRegExp';
 
 /**
  * Internal dependencies
@@ -18,11 +19,14 @@ function updateDomainState( state, domainName, dns ) {
 }
 
 function addDns( state, domainName, record ) {
-	const command = {
-		[ domainName ]: { records: { $push: [ record ] } }
-	};
+	const domainSuffix = new RegExp( '\\.' + escapeRegExp( domainName ) + '\\.$' ),
+		newRecord = Object.assign( {}, record, {
+			name: record.name.replace( domainSuffix, '' )
+		} );
 
-	return React.addons.update( state, command );
+	return React.addons.update( state, {
+		[ domainName ]: { records: { $push: [ newRecord ] } }
+	} );
 }
 
 function deleteDns( state, domainName, record ) {

diff --git a/client/my-sites/upgrades/domain-management/dns/dns-add-new.jsx b/client/my-sites/upgrades/domain-management/dns/dns-add-new.jsx
@@ -62,7 +62,7 @@ const DnsAddNew = React.createClass( {
 			initialFields: this.getInitialFields(),
 			onNewState: this.setFormState,
 			validatorFunction: ( fieldValues, onComplete ) => {
-				onComplete( null, validateAllFields( fieldValues ) );
+				onComplete( null, validateAllFields( fieldValues, this.props.selectedDomainName ) );
 			}
 		}	);