Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Domains: DNS: Fix bug with CNAME display after adding domain #1125

Merged
merged 3 commits into from
Dec 2, 2015
Merged

Domains: DNS: Fix bug with CNAME display after adding domain #1125

merged 3 commits into from
Dec 2, 2015

Conversation

rads
Copy link
Contributor

@rads rads commented Dec 1, 2015

Fixes an issue reported in p2MSmN-47K-p2.

Testing

  1. Go to http://calypso.localhost:3000/domains/manage
  2. Click on a registered or mapped domain and select "DNS Editor"
  3. Fill in a CNAME record. In the "Name" field you should only be able to add an address that ends with the currently selectd domain.
  4. When you add the record, the correct address should show up in the list.

@rads rads added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Feature Group] Emails & Domains Features related to email integrations and domain management. labels Dec 1, 2015
@rads rads self-assigned this Dec 1, 2015
@bikedorkjon
Copy link

👍

@matthusby
Copy link
Contributor

Code: 👍

@matthusby matthusby added [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 1, 2015
@rads rads force-pushed the fix/domain-management-cname-display branch 2 times, most recently from c45a0ee to 443452c Compare December 2, 2015 15:07
@rads rads changed the title Domain Management: DNS: Fix bug with CNAME display after adding domain Domains: DNS: Fix bug with CNAME display after adding domain Dec 2, 2015
@rads rads force-pushed the fix/domain-management-cname-display branch from 443452c to bd90210 Compare December 2, 2015 15:12
@rads rads force-pushed the fix/domain-management-cname-display branch from bd90210 to 9a52c6a Compare December 2, 2015 15:28
rads added a commit that referenced this pull request Dec 2, 2015
@rads
Merge pull request #1125 from Automattic/fix/domain-management-cname-…
8f20724 
…display

Domains: DNS: Fix bug with CNAME display after adding domain
@rads rads merged commit 8f20724 into master Dec 2, 2015
@lancewillett lancewillett deleted the fix/domain-management-cname-display branch December 22, 2015 19:14
@ajesse11x ajesse11x mentioned this pull request Nov 4, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Nov 5, 2022
Open
@ajesse11x ajesse11x mentioned this pull request Dec 25, 2022
Open
@awaisab172 awaisab172 mentioned this pull request Dec 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rads rads

Labels
[Feature Group] Emails & Domains Features related to email integrations and domain management.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rads @bikedorkjon @matthusby