Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-merge "[E2E] Embed block fixes" #45395

Merged

Conversation

fullofcaffeine
Copy link
Contributor

@fullofcaffeine fullofcaffeine commented Sep 3, 2020

#45345 had been merged before we released Gutenberg 8.9 and it had GB 8.9-specific changes. We needed to revert here: #45394. This basically "merges" #45345 again.

@matticbot
Copy link
Contributor

@fullofcaffeine fullofcaffeine changed the title Revert "Revert "[E2E] Embed block fixes"" Re-merge "[E2E] Embed block fixes" Sep 3, 2020
@fullofcaffeine fullofcaffeine self-assigned this Sep 3, 2020
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal sirreal added [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Ready to Merge and removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot labels Sep 7, 2020
@sirreal sirreal merged commit e5b122a into master Sep 8, 2020
@sirreal sirreal deleted the revert-45394-revert-45345-fix/gb-8.9-coblocks-2.2.2-e2e branch September 8, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs e2e Testing Gutenberg Edge Run e2e tests with a special site that is running the latest Gutenberg plugin snapshot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants