-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(@automattic/page-template-modal): Use the same dependencies than ETK #50114
Conversation
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~363 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~2 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~687 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D57123-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. 👍
Should we add a lint check to make sure we aren't using *
for versions? I think there must be some confusion about how to handle dependencies across the monorepo
f82f918
to
4e7373b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebased and no differences to the build outputs for me either using that diff command, LGTM 👍
That's an excellent idea! Once we reached "zero *" state (I think ETK was the only one left), I'll start working on some plugin for eslint to lint or package.json files. |
Changes proposed in this Pull Request
"*"
version ranges with the actual range extracted fromyarn.lock
Testing instructions
dist
files produced by ETK have not changed. To verify: build ETK in this branch and trunk, and diff all files insidedist/**/*
folders. Example:for file in apps/editing-toolkit/**/dist/**/*; do diff $file ../wp-calypso-trunk/$file; done