Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Toolkit: Update to v2.20 #50204

Merged
merged 3 commits into from
Feb 19, 2021
Merged

Conversation

andrewserong
Copy link
Member

@andrewserong andrewserong commented Feb 18, 2021

Changes proposed in this Pull Request

  • Bump version of Editing Toolkit plugin to 2.20

Editing toolkit changes included in this release

Other changes included from the imported @automattic packages and their imports

Testing instructions

  1. Load the diff on your sandbox (D57237-code) and confirm that the above changes work correctly
  2. When a change has been tested to work correctly, please mark it as checked in the list above
  3. Test that the new version of the plugin doesn't break Atomic sites by following the instructions in the "Atomic Testing" section at PCYsg-ly5-p2.
    • Tested on atomic with and without Gutenberg plugin active

@matticbot
Copy link
Contributor

@andrewserong andrewserong requested a review from a team February 18, 2021 00:46
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 18, 2021
@andrewserong andrewserong requested review from a team February 18, 2021 00:46
@andrewserong andrewserong self-assigned this Feb 18, 2021
@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D57237-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@creativecoder
Copy link
Contributor

I verified both of the following for Simple and Atomic sites

@StefanNieuwenhuis
Copy link
Contributor

Focused Launch - Summary View: Fix incorrect HE support link (#50115) - @StefanNieuwenhuis

Tested and works as expected 👍

@ciampo ciampo force-pushed the update/bump-etk-plugin-version-to-2-20 branch from 6fd2aee to 6ea13d1 Compare February 18, 2021 10:19
@ciampo ciampo added the Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin label Feb 18, 2021
@ciampo
Copy link
Contributor

ciampo commented Feb 18, 2021

  • Rebased on top of trunk to include latest changes
  • Added /packages related changes to the PR description

@ciampo
Copy link
Contributor

ciampo commented Feb 18, 2021

@StefanNieuwenhuis
Copy link
Contributor

Focused Launch: Only launch site if checkout is complete (#48452) @StefanNieuwenhuis @razvanpapadopol

Tested and the changes look good. It works as expected.

@StefanNieuwenhuis
Copy link
Contributor

Move page template modal into its own package (#49661) @roo2

I've tested this against production to see if there are any changes and haven't seen any changes. Since this is about moving code to a package, I assume that this is expected, but since there weren't any testing instructions in the PR, I cannot be 100% sure.

@ciampo ciampo force-pushed the update/bump-etk-plugin-version-to-2-20 branch from 6ea13d1 to 4aba875 Compare February 18, 2021 14:50
@ciampo
Copy link
Contributor

ciampo commented Feb 18, 2021

All changes included so far have been tested on simple sites.

On hold as we investigate errors on Atomic sites, potentially related to wpcom-block-editor plugin (which would be required by this version of ETK). See p1613660495322200-slack-C02DQP0FP

@ciampo
Copy link
Contributor

ciampo commented Feb 18, 2021

On hold as we investigate errors on Atomic sites

This should be fixed after merging #50237.

Rebased to include latest changes and tested #50241 on simple sites.

@andrewserong andrewserong force-pushed the update/bump-etk-plugin-version-to-2-20 branch from 6fb5ae7 to 311c8eb Compare February 19, 2021 03:24
@andrewserong
Copy link
Member Author

Rebased to include a fix for the page layout picker, I believe this release is now ready to land.

Copy link

@razvanpapadopol razvanpapadopol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke tested atomic with and without Gutenberg plugin active after WBE fix from #50237
Looks ready to 🚢

@ciampo ciampo force-pushed the update/bump-etk-plugin-version-to-2-20 branch from 311c8eb to 0e0ac86 Compare February 19, 2021 08:15
@ciampo
Copy link
Contributor

ciampo commented Feb 19, 2021

Rebased in order to include #50250

@ciampo
Copy link
Contributor

ciampo commented Feb 19, 2021

We weren't able to test for #50250 because we didn't know how to follow the instructions, although by looking at the code changes, they are only CSS removals — should be pretty safe (cc @Addison-Stavlo)

@ciampo ciampo merged commit a3224be into trunk Feb 19, 2021
@ciampo ciampo deleted the update/bump-etk-plugin-version-to-2-20 branch February 19, 2021 08:56
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 19, 2021
@ciampo
Copy link
Contributor

ciampo commented Feb 19, 2021

Cleanup patches:

  • remove 2.16: D57332-code
  • remove 2.17: D57334-code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants