-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editing Toolkit: Update to v2.20 #50204
Conversation
Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com D57237-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2 |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
I verified both of the following for Simple and Atomic sites
|
Tested and works as expected 👍 |
6fd2aee
to
6ea13d1
Compare
|
|
Tested and the changes look good. It works as expected. |
I've tested this against production to see if there are any changes and haven't seen any changes. Since this is about moving code to a package, I assume that this is expected, but since there weren't any testing instructions in the PR, I cannot be 100% sure. |
6ea13d1
to
4aba875
Compare
All changes included so far have been tested on simple sites. On hold as we investigate errors on Atomic sites, potentially related to wpcom-block-editor plugin (which would be required by this version of ETK). See p1613660495322200-slack-C02DQP0FP |
0606578
to
6fb5ae7
Compare
6fb5ae7
to
311c8eb
Compare
Rebased to include a fix for the page layout picker, I believe this release is now ready to land. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Smoke tested atomic with and without Gutenberg plugin active after WBE fix from #50237
Looks ready to 🚢
311c8eb
to
0e0ac86
Compare
Rebased in order to include #50250 |
We weren't able to test for #50250 because we didn't know how to follow the instructions, although by looking at the code changes, they are only CSS removals — should be pretty safe (cc @Addison-Stavlo) |
Cleanup patches:
|
Changes proposed in this Pull Request
Editing toolkit changes included in this release
Other changes included from the imported @automattic packages and their imports
Testing instructions