Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add missing translators comments in ETK components #50190

Merged
merged 1 commit into from
Feb 18, 2021
Merged

i18n: Add missing translators comments in ETK components #50190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/editing-toolkit/editing-toolkit-plugin/dotcom-fse/blocks/template/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,10 @@ const TemplateEdit = compose(
{ navigateToTemplate && (
<div className="template-block__loading">
<Spinner />{ ' ' }
{ sprintf( __( 'Loading editor for: %s', 'full-site-editing' ), templateTitle ) }
{
/* translators: %s is a template title. */
sprintf( __( 'Loading editor for: %s', 'full-site-editing' ), templateTitle )
}
</div>
) }
<Button
Expand All @@ -188,7 +191,10 @@ const TemplateEdit = compose(
isLarge
ref={ navButton }
>
{ sprintf( __( 'Edit %s', 'full-site-editing' ), templateTitle ) }
{
/* translators: %s is a template title. */
sprintf( __( 'Edit %s', 'full-site-editing' ), templateTitle )
}
</Button>
</Placeholder>
</Fragment>
Expand Down
3 changes: 3 additions & 0 deletions apps/editing-toolkit/editing-toolkit-plugin/dotcom-fse/lib/site-options/use-site-options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@ export function useSiteOptions(
)
.catch( () => {
createErrorNotice(
/* translators: %s is a site option (e.g. `title`, `description`, etc.). */
sprintf( __( 'Unable to load site %s', 'full-site-editing' ), siteOption )
);
setSiteOptions( {
...siteOptions,
/* translators: %s is a site option (e.g. `title`, `description`, etc.). */
option: sprintf( __( 'Error loading site %s', 'full-site-editing' ), siteOption ),
error: true,
} );
Expand Down Expand Up @@ -94,6 +96,7 @@ export function useSiteOptions(
.then( () => updatePreviousOption( option ) )
.catch( () => {
createErrorNotice(
/* translators: %s is a site option (e.g. `title`, `description`, etc.). */
sprintf( __( 'Unable to save site %s', 'full-site-editing' ), siteOption )
);
revertOption();
Expand Down
10 changes: 4 additions & 6 deletions apps/editing-toolkit/editing-toolkit-plugin/global-styles/src/no-support.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@ import { __, sprintf } from '@wordpress/i18n';

export default ( { unsupportedFeature } ) => (
<p>
{
{ sprintf(
/* translators: %s: feature name (i.e. font pairings, etc) */
sprintf(
__( "Your active theme doesn't support %s.", 'full-site-editing' ),
unsupportedFeature
)
}
__( "Your active theme doesn't support %s.", 'full-site-editing' ),
unsupportedFeature
) }
</p>
);