Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Add missing translators comments in ETK components #50190

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

yuliyan
Copy link
Member

@yuliyan yuliyan commented Feb 17, 2021

Changes proposed in this Pull Request

  • Add missing translators comments in ETK components

Testing instructions

  • Check if translators comments make sense.

Related to #49312

@yuliyan yuliyan added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. i18n labels Feb 17, 2021
@yuliyan yuliyan requested review from a team and oandregal February 17, 2021 16:31
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D57205-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

Copy link
Contributor

@dlind1 dlind1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the artifacts and all the translator comments were present. 👍

@yuliyan yuliyan changed the base branch from add/wordpress-eslint-plugin-i18n-ruleset to trunk February 18, 2021 08:30
@yuliyan yuliyan merged commit 8a5de3c into trunk Feb 18, 2021
@yuliyan yuliyan deleted the fix/add-missing-translator-comments-in-etk branch February 18, 2021 08:32
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 18, 2021
@ciampo ciampo mentioned this pull request Feb 18, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants