Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plans-grid: Fix translators comment format #50191

Merged
merged 2 commits into from
Feb 18, 2021

Conversation

yuliyan
Copy link
Member

@yuliyan yuliyan commented Feb 17, 2021

Fix translators comment in PlansIntervalToggle component to be on a single line so it fulfils @wordpress/i18n-translator-comments lint rules

Changes proposed in this Pull Request

  • Format translators comment in PlansIntervalToggle component to be on a single line

Testing instructions

  • Confirm lint problem has been resolved in Check code style for branches (Calypso).

Related to #49312

Fix translators comment in PlansIntervalToggle component to be on a single line so it fulfils @wordpress/i18n-translator-comments lint rules
@yuliyan yuliyan added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. i18n labels Feb 17, 2021
@yuliyan yuliyan requested review from ciampo and a team February 17, 2021 16:39
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@dlind1 dlind1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No errors for packages/plans-grid/src/plans-interval-toggle/index.tsx appear in TC report anymore, the translator comment is also being extracted. 👍

Copy link
Contributor

@ciampo ciampo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — I just suggested a small change that fixes the position of the closing quote " sign

packages/plans-grid/src/plans-interval-toggle/index.tsx Outdated Show resolved Hide resolved
Co-authored-by: Marco Ciampini <[email protected]>
@yuliyan yuliyan merged commit 505c56f into trunk Feb 18, 2021
@yuliyan yuliyan deleted the fix/translators-comment-format-in-plans-grid branch February 18, 2021 08:32
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 18, 2021
@ciampo ciampo mentioned this pull request Feb 18, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants