Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch: Fix logic to compute redirectToWpcomPath origin #50241

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Feb 18, 2021

Changes proposed in this Pull Request

  • Fix the logic for computing the origin in the redirectToWpcomPath function

Testing instructions

Setup

  • Create a site with /start and add it to the sandbox (do not launch it)
  • Enable Focused Launch flow A/B testing experiment

Test in Calypso

  • Click "Launch" in the block editor on Calypso
  • Click on "View all domains"
  • Click on "Use a domain I own"
    • You should be redirected correctly to the domain transfer launch flow
  • Click on the back link on the top left of the page
    • You should be redirected to the block editor
  • Open Focused Launch modal again, and pick free subdomain and a paid plan
  • Click Launch
    • You should be redirected to the correct checkout page

Test in WP Admin

Repeat steps above, but from the WP Admin block editor instead

Related to #50242

@matticbot
Copy link
Contributor

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 18, 2021
@ciampo ciampo self-assigned this Feb 18, 2021
@ciampo ciampo added Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin Focused Launch Issues and PRs related to Focused Launch Feature [Launch] Launching a site from Coming Soon to Published. Post-launch labels Feb 18, 2021
Copy link
Contributor

@StefanNieuwenhuis StefanNieuwenhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 🚢

@ciampo ciampo mentioned this pull request Feb 18, 2021
20 tasks
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Contributor

Caution: This PR affects files in the Editing Toolkit Plugin on WordPress.com
Please ensure your changes work on WordPress.com before merging.

D57284-code has been created so you can easily test it on your sandbox. See this FieldGuide page about developing the Editing Toolkit Plugin for more info: PCYsg-ly5-p2

@ciampo ciampo merged commit 79b116d into trunk Feb 18, 2021
@ciampo ciampo deleted the fix/launch-redirect-to-wpcom-base-url branch February 18, 2021 18:02
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editing Toolkit For issues and PRs that affect the Editing Toolkit plugin Feature [Launch] Launching a site from Coming Soon to Published. Focused Launch Issues and PRs related to Focused Launch Post-launch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants