Skip to content

Commit

Permalink
fix: dry run on grind (#12088)
Browse files Browse the repository at this point in the history
Prevents the docker push from failing in grind jobs where
DOCKERHUB_PASSWORD isnt set
  • Loading branch information
ludamad authored Feb 18, 2025
1 parent 8471b54 commit 3b8f876
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/ci3.yml
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ jobs:
ARCH: amd64
LOG_ID: ${{ github.run_id }}
INSTANCE_POSTFIX: ${{ matrix.number }}
DRY_RUN: 1
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
./ci.sh ec2-test
Expand Down
3 changes: 2 additions & 1 deletion ci3/bootstrap_ec2
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,13 @@ container_script=$(cat <<EOF
git checkout FETCH_HEAD
git checkout -b $REF_NAME
export CI_FULL=$CI_FULL
export DRY_RUN=${DRY_RUN:-0}
source ci3/source
if [ -n "${DOCKERHUB_PASSWORD:-}" ] && ([ "$REF_NAME" == "master" ] || semver check "$REF_NAME"); then
echo ${DOCKERHUB_PASSWORD:-} | docker login -u aztecprotocolci --password-stdin
fi
echo "env: REF_NAME=$REF_NAME COMMIT_HASH=$COMMIT_HASH CURRENT_VERSION=$CURRENT_VERSION CI_FULL=$CI_FULL"
echo "env: REF_NAME=$REF_NAME COMMIT_HASH=$COMMIT_HASH CURRENT_VERSION=$CURRENT_VERSION CI_FULL=$CI_FULL DRY_RUN=${DRY_RUN:-0}"
if semver check "$REF_NAME"; then
echo "Performing a release because $REF_NAME is a semver."
fi
Expand Down

1 comment on commit 3b8f876

@AztecBot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'C++ Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.05.

Benchmark suite Current: 3b8f876 Previous: f1ba015 Ratio
wasmconstruct_proof_ultrahonk_power_of_2/20 12169.630596 ms/iter 9816.247989000001 ms/iter 1.24

This comment was automatically generated by workflow using github-action-benchmark.

CC: @ludamad @codygunton

Please sign in to comment.