Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dry run on grind #12088

Merged
merged 1 commit into from
Feb 18, 2025
Merged

fix: dry run on grind #12088

merged 1 commit into from
Feb 18, 2025

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Feb 18, 2025

Prevents the docker push from failing in grind jobs where DOCKERHUB_PASSWORD isnt set

@ludamad ludamad requested a review from charlielye as a code owner February 18, 2025 18:30
@ludamad ludamad enabled auto-merge (squash) February 18, 2025 18:39
@ludamad ludamad disabled auto-merge February 18, 2025 21:16
@ludamad ludamad merged commit 3b8f876 into master Feb 18, 2025
10 checks passed
@ludamad ludamad deleted the ad/dryrun-on-grind branch February 18, 2025 21:16
TomAFrench added a commit that referenced this pull request Feb 19, 2025
* master: (245 commits)
  chore: Fix unbound CI variable on release image bootstrap (#12095)
  fix: dry run on grind (#12088)
  fix(spartan): eth-execution logging (#12094)
  fix: aws_handle_evict recovery & termination (#12086)
  chore: Use native acvm when available on orchestrator tests (#11560)
  refactor: function macros cleanup (#12066)
  refactor: remove `addNullifiedNote` from pxe (#11822)
  fix: `#[aztec]` macro warnings (#12038)
  refactor!: Notes implementing `Packable<N>` (#12004)
  chore(ops): add gcloud cli into devbox base image (#12082)
  fix: hotfix grinding
  fix: L1 deployment on reth (#12060)
  fix: Add missing bootstrap fast aliases (#12078)
  fix: hash_str caching (#12074)
  fix: Naive attempt to fix nightly deployments (#12079)
  fix: kind smoke (#12084)
  refactor!: nuking `NoteHeader` (#11942)
  fix: inject dockerhub creds (#12072)
  feat(docs): Note discovery concepts page (#11760)
  chore: cleanup libp2p logger (#12058)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant