fix: L1 deployment on reth #12060
Merged
fix: L1 deployment on reth #12060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalladino
commented
Feb 17, 2025
| @@ -17,6 +17,7 @@ services: | |||
| - "${PWD}/out/jwt-secret.hex:/genesis/jwt-secret.hex" | |||
| environment: | |||
| - HTTP_PORT=8545 | |||
| - WS_PORT=8546 | |||
There was a problem hiding this comment.
run-locally was failing without this since #11922
spalladino
commented
Feb 17, 2025
| @@ -3,4 +3,4 @@ | |||
| REPO_ROOT=$(git rev-parse --show-toplevel) | |||
|
|
|||
| ${REPO_ROOT}/spartan/aztec-network/eth-devnet/create.sh | |||
| (cd ${REPO_ROOT}/spartan/aztec-network/eth-devnet && docker compose build && docker compose up) | |||
| (cd ${REPO_ROOT}/spartan/aztec-network/eth-devnet && docker compose down -v && docker compose build && docker compose up) | |||
There was a problem hiding this comment.
The down -v ensures volumes are cleaned up. Otherwise the containers will use the volumes with the config from an old create.sh run and fail to start.
PhilWindle
approved these changes
Feb 18, 2025
Maddiaa0
approved these changes
Feb 18, 2025
spalladino
force-pushed
the
palla/fix-l1-deploy-on-reth
branch
from
b68725a to
61a160b
Compare
spalladino
force-pushed
the
palla/fix-l1-deploy-on-reth
branch
from
4040dcf to
66f41f3
Compare
spalladino
force-pushed
the
palla/fix-l1-deploy-on-reth
branch
from
66f41f3 to
5c25f61
Compare
TomAFrench
added a commit
that referenced
this pull request
Feb 19, 2025
* master: (245 commits) chore: Fix unbound CI variable on release image bootstrap (#12095) fix: dry run on grind (#12088) fix(spartan): eth-execution logging (#12094) fix: aws_handle_evict recovery & termination (#12086) chore: Use native acvm when available on orchestrator tests (#11560) refactor: function macros cleanup (#12066) refactor: remove `addNullifiedNote` from pxe (#11822) fix: `#[aztec]` macro warnings (#12038) refactor!: Notes implementing `Packable<N>` (#12004) chore(ops): add gcloud cli into devbox base image (#12082) fix: hotfix grinding fix: L1 deployment on reth (#12060) fix: Add missing bootstrap fast aliases (#12078) fix: hash_str caching (#12074) fix: Naive attempt to fix nightly deployments (#12079) fix: kind smoke (#12084) refactor!: nuking `NoteHeader` (#11942) fix: inject dockerhub creds (#12072) feat(docs): Note discovery concepts page (#11760) chore: cleanup libp2p logger (#12058) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes deployment of L1 contracts with salt on reth. The deployment was failing because
rethfails to estimate gas when deploying a contract that relies on external libraries deployed in an unmined tx. This PR makes the deployment of the contract to wait for dependent libraries to be deployed.Unfortunately I didn't manage to get eth-devnet into unit tests, but added env vars to configure the
deploy-l1-contractstest to try it locally.Fixes #11576