Update DPG ResponseClassifiers #2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShivangiReja
commented
Mar 2, 2022
Comment on lines
+196
to
200
| private sealed class ResponseClassifier200To300400To500Override : ResponseClassifier | ||
| { | ||
| private static ResponseClassifier _instance; | ||
| public static ResponseClassifier Instance => _instance ??= new ResponseClassifier200To300400To500(); | ||
| public override bool IsErrorResponse(HttpMessage message) | ||
| { | ||
| return message.Response.Status switch |
There was a problem hiding this comment.
Here is the generated code for ResponseClassifier200To300400To500 based on #2006 (comment)
ShivangiReja
commented
Mar 2, 2022
Comment on lines
152
to
153
| private static ResponseClassifier _responseClassifier200; | ||
| private static ResponseClassifier ResponseClassifier200 => _responseClassifier200 ??= new CoreResponseClassifier(stackalloc int[] { 200 }); |
There was a problem hiding this comment.
Here is the generated code for ResponseClassifier200 based on #2006 (comment)
ShivangiReja
changed the title
src/AutoRest.CSharp/LowLevel/Generation/LowLevelClientWriter.cs
Outdated
Show resolved
Hide resolved
|
Reason for this PR failure - #2025 (comment) |
ShivangiReja
commented
Mar 2, 2022
test/TestServerProjectsLowLevel/head/Generated/HttpSuccessClient.cs
Outdated
Show resolved
Hide resolved
|
Once Azure/azure-sdk-for-net#27379 merges, we will need to change the CoreResponseClassifier name to StatusCodeClassifier. Probably better to hold this until that happens. |
…into ResponseClassifier
…into ResponseClassifier
annelo-msft
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2006