Update latest Azure.Core version to 1.23.0-alpha.20220301.6 #2025
Conversation
|
Updating latest Azure.Core version results DPG generated HttpRetryClient test failures for all the methods. Here are the tests for |
|
This is a known bug: Azure/azure-sdk-for-net#27166 |
| @@ -595,7 +595,7 @@ public async Task<Response<IndexerExecutionInfo>> GetStatusAsync(string indexerN | |||
| /// <param name="requestOptions"> Parameter group. </param> | |||
| /// <param name="cancellationToken"> The cancellation token to use. </param> | |||
| /// <exception cref="ArgumentNullException"> <paramref name="indexerName"/> is null. </exception> | |||
| public Response<IndexerExecutionInfo> GetStatus(string indexerName, RequestOptions requestOptions = null, CancellationToken cancellationToken = default) | |||
| public Response<IndexerExecutionInfo> GetStatus(string indexerName, Models.RequestOptions requestOptions = null, CancellationToken cancellationToken = default) | |||
There was a problem hiding this comment.
Why Models is added here rather than in using namespace?
There was a problem hiding this comment.
We added a new RequestOptions type in Azure.Core and I think it added Models. to resolve the conflict(I didn't do any change related to this).
There was a problem hiding this comment.
ah yes that would explain it. @AlexanderSher are we good to go here?
There was a problem hiding this comment.
The RequestOptions in Azure.Core is in the Azure namespace, e.g. Azure.RequestOptions. I'm not sure what the one in the Models namespace is, @ShivangiReja, do you know?
There was a problem hiding this comment.
Responded here - #2025 (comment)
There was a problem hiding this comment.
Ah, I see! There is another RequestOptions coming from Search, and it's not the DPG one!
| @@ -45,7 +45,7 @@ internal DataSourcesClient(ClientDiagnostics clientDiagnostics, HttpPipeline pip | |||
| /// <param name="requestOptions"> Parameter group. </param> | |||
| /// <param name="accessCondition"> Parameter group. </param> | |||
| /// <param name="cancellationToken"> The cancellation token to use. </param> | |||
| public virtual async Task<Response<DataSource>> CreateOrUpdateAsync(string dataSourceName, Enum0 prefer, DataSource dataSource, RequestOptions requestOptions = null, AccessCondition accessCondition = null, CancellationToken cancellationToken = default) | |||
| public virtual async Task<Response<DataSource>> CreateOrUpdateAsync(string dataSourceName, Enum0 prefer, DataSource dataSource, Models.RequestOptions requestOptions = null, AccessCondition accessCondition = null, CancellationToken cancellationToken = default) | |||
There was a problem hiding this comment.
Where is the configuration that specifies this generated method should take RequestOptions as a parameter?
There was a problem hiding this comment.
There is no configuration for RequestOptions. I see CodeModel.yaml file generated RequestOptions and put x-ms-request-id in it.
@timotheeguerin could you please explain why we create RequestOptions type in CodeModel.yaml?
There was a problem hiding this comment.
I talked to @timotheeguerin offline. Thanks @timotheeguerin for looking into this.
@annelo-msft RequestOption type is created because it is mentioned in the swagger here.
Update latest Azure.Core version to
1.23.0-alpha.20220301.6