[AppService] fix #12509: Remove the tag to az webapp up by default #12639
Conversation
|
add to S167 |
Kotasudhakarreddy
changed the title
|
@panchagnula and @ThejaChoudary - FYI |
| @@ -130,8 +130,7 @@ def test_webapp_up_python_e2e(self, resource_group): | |||
| ]) | |||
|
|
|||
| self.cmd('webapp config show', checks=[ | |||
| JMESPathCheck('linuxFxVersion', result['runtime_version']), | |||
| JMESPathCheck('tags.cli', 'webapp_up'), | |||
There was a problem hiding this comment.
can we just update this validation to tags.cli [] instead of removing the lime completely?
There was a problem hiding this comment.
this update needs to be made at 2 others places on this same file. Please make sure you run all tests in this file with --live flag
| @@ -130,8 +130,7 @@ def test_webapp_up_python_e2e(self, resource_group): | |||
| ]) | |||
|
|
|||
| self.cmd('webapp config show', checks=[ | |||
| JMESPathCheck('linuxFxVersion', result['runtime_version']), | |||
| JMESPathCheck('tags.cli', 'webapp_up'), | |||
There was a problem hiding this comment.
this update needs to be made at 2 others places on this same file. Please make sure you run all tests in this file with --live flag
|
@btardif FYI. |
|
Can you share why remove this tag? Thank you! |
These tags are added by default when creating app using |
OK. Thanks. |
qwordy
changed the title
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.