Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppService] fix #12509: Remove the tag to az webapp up by default #12639

Merged
merged 3 commits into from
Mar 20, 2020
+5 −5
Merged

[AppService] fix #12509: Remove the tag to az webapp up by default #12639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2caa594
12509-webapp: Remove the tag to az webapp up by default
Kotasudhakarreddy Mar 18, 2020
bdae1dd
Webapps-fixed CLI style build failure issue
Kotasudhakarreddy Mar 18, 2020
f831d23
[webapp] fix #12509: Fixed review comments.
Kotasudhakarreddy Mar 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/azure-cli/azure/cli/command_modules/appservice/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3219,7 +3219,7 @@ def webapp_up(cmd, name, resource_group_name=None, plan=None, location=None, sku

if _create_new_app:
logger.warning("Creating webapp '%s' ...", name)
create_webapp(cmd, rg_name, name, plan, runtime_version if _is_linux else None, tags={"cli": 'webapp_up'},
create_webapp(cmd, rg_name, name, plan, runtime_version if _is_linux else None,
using_webapp_up=True, language=language)
_configure_default_logging(cmd, rg_name, name)
else: # for existing app if we might need to update the stack runtime settings
Expand Down
8 changes: 4 additions & 4 deletions src/azure-cli/azure/cli/command_modules/appservice/tests/latest/test_webapp_up_commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def test_webapp_up_node_e2e(self, resource_group):

self.cmd('webapp config show', checks=[
JMESPathCheck('linuxFxVersion', result['runtime_version']),
JMESPathCheck('tags.cli', 'webapp_up'),
JMESPathCheck('tags.cli', 'None'),
])

self.cmd('webapp config appsettings list', checks=[
Expand Down Expand Up @@ -131,7 +131,7 @@ def test_webapp_up_python_e2e(self, resource_group):

self.cmd('webapp config show', checks=[
JMESPathCheck('linuxFxVersion', result['runtime_version']),
JMESPathCheck('tags.cli', 'webapp_up'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we just update this validation to tags.cli [] instead of removing the lime completely?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this update needs to be made at 2 others places on this same file. Please make sure you run all tests in this file with --live flag

JMESPathCheck('tags.cli', 'None'),
])

self.cmd('webapp config appsettings list', checks=[
Expand Down Expand Up @@ -198,7 +198,7 @@ def test_webapp_up_dotnetcore_e2e(self, resource_group):
])

self.cmd('webapp config show', checks=[
JMESPathCheck('tags.cli', 'webapp_up'),
JMESPathCheck('tags.cli', 'None'),
JMESPathCheck('windowsFxVersion', None)
])

Expand Down Expand Up @@ -267,7 +267,7 @@ def test_webapp_up_statichtml_e2e(self, resource_group):
])

self.cmd('webapp config show', checks=[
JMESPathCheck('tags.cli', 'webapp_up'),
JMESPathCheck('tags.cli', 'None'),
JMESPathCheck('windowsFxVersion', None)
])

Expand Down