[Compute] VM NIC updates #1421
Merged
[Compute] VM NIC updates #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjprescott
added
Breaking Change
Compute
|
@tjprescott, thanks for your PR! By analyzing the history of the files in this pull request, we identified @BurtBiel, @derekbekoe and @yugangw-msft to be potential reviewers. |
| register_cli_argument('vm nic', 'vm_name', existing_vm_name, id_part=None) | ||
| register_cli_argument('vm nic', 'nic_ids', multi_ids_type) | ||
| register_cli_argument('vm nic', 'nic_names', multi_ids_type) | ||
| register_cli_argument('vm nic', 'vm_name', existing_vm_name, options_list=('--vm-name',), id_part=None) |
There was a problem hiding this comment.
is options_list=('--vm-name',) redundant?
There was a problem hiding this comment.
No, because existing_vm_name would make it --name, which isn't correct here.
| cli_command(__name__, 'vm open-port', 'azure.cli.command_modules.vm.custom#vm_open_port') | ||
| op_var = 'virtual_machines_operations' | ||
| op_class = 'VirtualMachinesOperations' | ||
| cli_command(__name__, 'vm delete', mgmt_path.format(op_var, op_class, 'delete'), cf_vm) |
There was a problem hiding this comment.
//cc @derekbekoe. I am fine with this new style. As long as we agree, let us propagate this style across moving forward
| def vm_show_nic(resource_group_name, vm_name, nic=None): | ||
| ''' Show details of a network interface configuration attached to a virtual machine ''' | ||
| vm = _vm_get(resource_group_name, vm_name) | ||
| found = next((n for n in vm.network_profile.network_interfaces if nic in n.id), None) # pylint: disable=no-member |
There was a problem hiding this comment.
nic in n.id should consider case insensitive matching. Also is nic always a id? If not, then in is not a reliable matching as it is possible the nic name will collide with any sub-str in the id.
There was a problem hiding this comment.
It is. The validator essentially takes names or ids and converts them to ids. I'll add the case insensitivity and change the matching to ==
derekbekoe
reviewed
Nov 23, 2016
| @@ -693,20 +691,37 @@ def show_default_diagnostics_configuration(is_windows_os=False): | |||
| '''show the default config file which defines data to be collected''' | |||
| return get_default_diag_config(is_windows_os) | |||
|
|
|||
| def vm_add_nics(resource_group_name, vm_name, nic_ids=None, nic_names=None, primary_nic=None): | |||
| '''add network interface configurations to the virtual machine | |||
| def vm_show_nic(resource_group_name, vm_name, nic=None): | |||
There was a problem hiding this comment.
Why is nic optional?
Lower down, you have if nic in n.id.
There was a problem hiding this comment.
It should be required.
derekbekoe
approved these changes
Nov 23, 2016
|
|
thegalah
pushed a commit
to thegalah/azure-cli
that referenced
this pull request
Nov 28, 2016
* Azure/master: (39 commits) User should use no-cache so we build a fresh image (Azure#1455) Bump all modules to version 0.1.0b10 (Azure#1454) [Docs] Move around the order of install instructions. (Azure#1439) acs: *_install_cli mark cli as executable (Azure#1449) Fix resource list table. (Azure#1452) [Compute] VM NIC updates (Azure#1421) Introduce batch upload and download for blob (Azure#1428) Add auto-registration for resource providers. (Azure#1330) interpret the '@' syntax if something higher hasn't already done that. (Azure#1423) Aliasing plan argument with shorthand (Azure#1433) ad:fix one more place which still uses localtime for secret starttime (Azure#1429) Add table formatting for deployments and sort by timestmap. (Azure#1427) Add table formatting for resource group list (and add 'status') (Azure#1425) [Docs] Add shields specifying latest version and supported python versions (Azure#1420) Add new az storage blob copy start-batch command (Azure#1250) Component Discovery (Azure#1409) Add poison logic to prevent re-recording tests that need updating. (Azure#1412) [Storage] Fix storage table outputs and help text. (Azure#1402) [mention-bot] Attempt to fix config (Azure#1410) ad:use utc time on setting app's creds (Azure#1408) ...
xscript
pushed a commit
to xscript/azure-cli
that referenced
this pull request
Nov 30, 2016
**BC** Replace --nic-ids and --nic-names with --nics parameter for existing `vm nic` commands. **BC** Renames `vm nic delete` to `vm nic remove` and `vm nic update` to `vm nic set` * Add NIC show and list commands to VM NIC. * Code review feedback.
haroldrandom
added
Breaking Change
cla-not-required
Compute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #783, fixes #785.
vm nic show(which is basically an alias ofaz network nic show) andvm nic list--nic-idsand--nic-namesinto a single--nicsparameter for existing commands Breaking Changevm niccommands into VM multi-NIC create scenario instead of relying on unit tests.vm nic deletetovm nic removesince it does NOT actually delete a NIC. Renamesvm nic updatetovm nic setsince it does not update the settings but in fact replaces them. Breaking Change