Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acs: *_install_cli mark cli as executable #1449

Merged
merged 1 commit into from
Nov 28, 2016
Merged

acs: *_install_cli mark cli as executable #1449

merged 1 commit into from
Nov 28, 2016

Conversation

colemickens
Copy link
Contributor

Addresses #1447.

@mention-bot
Copy link

@colemickens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @brendandburns, @sanar-microsoft and @PeterJausovec to be potential reviewers.

@azurecla
Copy link

Hi @colemickens, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!


It looks like you're working at Microsoft (colemick). If you're full-time, we DON'T require a contribution license agreement.



If you are a vendor, DO please sign the electronic contribution license agreement. It will take 2 minutes and there's no faxing! https://cla.azure.com.

TTYL, AZPRBOT;

@colemickens
Copy link
Contributor Author

Checked also, this is safe on Windows:

Although Windows supports chmod(), you can only set the file’s read-only flag with it (via the stat.S_IWRITE and stat.S_IREAD constants or a corresponding integer value). All other bits are ignored.

@lostintangent
Copy link
Member

LGTM! This also resolves #1395.

derekbekoe
derekbekoe approved these changes Nov 28, 2016
View reviewed changes
Copy link
Member

@derekbekoe derekbekoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derekbekoe derekbekoe merged commit 97fb037 into Azure:master Nov 28, 2016
thegalah pushed a commit to thegalah/azure-cli that referenced this pull request Nov 28, 2016
Merge remote-tracking branch 'Azure/master'
7495297 
* Azure/master: (39 commits)
  User should use no-cache so we build a fresh image (Azure#1455)
  Bump all modules to version 0.1.0b10 (Azure#1454)
  [Docs] Move around the order of install instructions. (Azure#1439)
  acs: *_install_cli mark cli as executable (Azure#1449)
  Fix resource list table. (Azure#1452)
  [Compute] VM NIC updates (Azure#1421)
  Introduce batch upload and download for blob (Azure#1428)
  Add auto-registration for resource providers. (Azure#1330)
  interpret the '@' syntax if something higher hasn't already done that. (Azure#1423)
  Aliasing plan argument with shorthand (Azure#1433)
  ad:fix one more place which still uses localtime for secret starttime (Azure#1429)
  Add table formatting for deployments and sort by timestmap. (Azure#1427)
  Add table formatting for resource group list (and add 'status') (Azure#1425)
  [Docs] Add shields specifying latest version and supported python versions (Azure#1420)
  Add new az storage blob copy start-batch command (Azure#1250)
  Component Discovery (Azure#1409)
  Add poison logic to prevent re-recording tests that need updating. (Azure#1412)
  [Storage] Fix storage table outputs and help text. (Azure#1402)
  [mention-bot] Attempt to fix config (Azure#1410)
  ad:use utc time on setting app's creds (Azure#1408)
  ...
@colemickens colemickens mentioned this pull request Nov 29, 2016
Closed
@brendandburns brendandburns mentioned this pull request Nov 30, 2016
Closed
xscript pushed a commit to xscript/azure-cli that referenced this pull request Nov 30, 2016
@colemickens
acs: *_install_cli mark cli as executable (Azure#1449)
2d33076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekbekoe derekbekoe derekbekoe approved these changes

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@colemickens @mention-bot @azurecla @lostintangent @derekbekoe @haroldrandom