{Packaging} Bump requests and urllib3 and loosen dependencies in setup.py
#19801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
requested review from
evelyn-ys,
jsntcy,
kairu-ms and
zhoxing-ms
as code owners
jiasli
commented
Oct 8, 2021
| @@ -146,6 +146,7 @@ | |||
| 'scp~=0.13.2', | |||
| 'semver==2.13.0', | |||
| 'sshtunnel~=0.1.4', | |||
| 'urllib3[secure]', | |||
There was a problem hiding this comment.
Core doesn't directly depend on urllib3.
jiasli
changed the title
requests and urllib3 and loosen dependencies in setup.py
|
Packaging |
yonzhan
modified the milestones:
Oct 2021 (2021-11-02) - For Ignite,
Nov 2021 (2021-12-07)
evelyn-ys
approved these changes
Nov 17, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #18499, #19682
Bump
requestsandurllib3and loosen dependencies insetup.py.Being too strict on versions can frequently leads to endless backtracking in latest
pip(#18324, #18518) .Now we don't want to be too specific on versions. Instead, the user should be responsible for security vulnerabilities in older versions of dependencies, same as #19639.