Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cryptography from 38.0.4 to 41.0.0 in /src/azure-cli #26596

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 2, 2023

Bumps cryptography from 38.0.4 to 41.0.0.

Changelog

Sourced from cryptography's changelog.

41.0.0 - 2023-05-30


* **BACKWARDS INCOMPATIBLE:** Support for OpenSSL less than 1.1.1d has been
  removed.  Users on older version of OpenSSL will need to upgrade.
* **BACKWARDS INCOMPATIBLE:** Support for Python 3.6 has been removed.
* **BACKWARDS INCOMPATIBLE:** Dropped support for LibreSSL < 3.6.
* Updated the minimum supported Rust version (MSRV) to 1.56.0, from 1.48.0.
* Updated Windows, macOS, and Linux wheels to be compiled with OpenSSL 3.1.1.
* Added support for the :class:`~cryptography.x509.OCSPAcceptableResponses`
  OCSP extension.
* Added support for the :class:`~cryptography.x509.MSCertificateTemplate`
  proprietary Microsoft certificate extension.
* Implemented support for equality checks on all asymmetric public key types.
* Added support for ``[email protected]`` encrypted keys in
  :func:`~cryptography.hazmat.primitives.serialization.load_ssh_private_key`.
* Added support for obtaining X.509 certificate signature algorithm parameters
  (including PSS) via
  :meth:`~cryptography.x509.Certificate.signature_algorithm_parameters`.
* Support signing :class:`~cryptography.hazmat.primitives.asymmetric.padding.PSS`
  X.509 certificates via the new keyword-only argument ``rsa_padding`` on
  :meth:`~cryptography.x509.CertificateBuilder.sign`.
* Added support for
  :class:`~cryptography.hazmat.primitives.ciphers.aead.ChaCha20Poly1305`
  on BoringSSL.

.. _v40-0-2:

40.0.2 - 2023-04-14

  • Fixed compilation when using LibreSSL 3.7.2.
  • Added some functions to support an upcoming pyOpenSSL release.

.. _v40-0-1:

40.0.1 - 2023-03-24


* Fixed a bug where certain operations would fail if an object happened to be
  in the top-half of the memory-space. This only impacted 32-bit systems.

.. _v40-0-0:

40.0.0 - 2023-03-24

  • BACKWARDS INCOMPATIBLE: As announced in the 39.0.0 changelog, the way cryptography links OpenSSL has changed. This only impacts users who

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [cryptography](https://github.com/pyca/cryptography) from 38.0.4 to 41.0.0.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@38.0.4...41.0.0)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@azure-client-tools-bot-prd
Copy link

Validation for Azure CLI Full Test Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jun 2, 2023
@ghost
Copy link

ghost commented Jun 2, 2023

Thank you for your contribution dependabot[bot]! We will review the pull request and get back to you soon.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 2, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@yonzhan yonzhan requested review from jiasli and bebound June 2, 2023 23:17
@jiasli
Copy link
Member

jiasli commented Jun 14, 2023

cryptography < 41.0.0 is impacted by GHSA-5cpq-8wj7-hf2v. #25544 is not enough, as cryptography 39.0.1 doesn't fix this CVE.

cryptography was deliberately rolled back by #25690 to avoid the warning message shown on 32-bit Python. The warning message is acceptable as it only appears on Windows and is only printed to stderr. We are working on Windows 64-bit MSI package in #26640.

@jiasli
Copy link
Member

jiasli commented Jun 14, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jiasli
Copy link
Member

jiasli commented Jun 14, 2023

Only bumping cryptography to 41.0.0 triggers error:

INFO: pip is looking at multiple versions of pyopenssl to determine which version is compatible with other requirements. This could take a while.
...
Collecting azure-cli==2.49.0 (from -r D:\cli\azure-cli\src\azure-cli\requirements.py3.Windows.txt (line 9))
  Downloading azure_cli-2.49.0-py3-none-any.whl (11.3 MB)
     ---------------------------------------- 11.3/11.3 MB 2.2 MB/s eta 0:00:00
Collecting azure-cli-core==2.49.0 (from -r D:\cli\azure-cli\src\azure-cli\requirements.py3.Windows.txt (line 7))
  Downloading azure_cli_core-2.49.0-py3-none-any.whl (241 kB)
     -------------------------------------- 241.4/241.4 kB 3.7 MB/s eta 0:00:00
INFO: pip is looking at multiple versions of azure-cli-core to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install -r D:\cli\azure-cli\src\azure-cli\requirements.py3.Windows.txt (line 7) and msal[broker]==1.22.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested msal[broker]==1.22.0
    azure-cli-core 2.49.0 depends on msal[broker]==1.20.0

It seems pip is looking at azure-cli-core from PyPI, instead of the source code.

The conflict actually comes from pyopenssl and cryptography:

> pip install pyOpenSSL==22.1.0 cryptography==41.0.0
Requirement already satisfied: pyOpenSSL==22.1.0 in d:\cli\py310\lib\site-packages (22.1.0)
Collecting cryptography==41.0.0
  Using cached cryptography-41.0.0-cp37-abi3-win_amd64.whl (2.6 MB)
INFO: pip is looking at multiple versions of pyopenssl to determine which version is compatible with other requirements. This could take a while.
ERROR: Cannot install cryptography==41.0.0 and pyopenssl==22.1.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested cryptography==41.0.0
    pyopenssl 22.1.0 depends on cryptography<39 and >=38.0.0

@jiasli
Copy link
Member

jiasli commented Jun 14, 2023

Will work in #26671.

@jiasli jiasli closed this Jun 14, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jun 14, 2023

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/pip/src/azure-cli/cryptography-41.0.0 branch June 14, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer-reported Issues that are reported by GitHub users external to the Azure organization. External Dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants