{Packaging} Bump cryptography to 41.0.1 and pyOpenSSL to 23.2.0 on Linux and MacOS #26671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
requested review from
ghost
added
the
|
Discussion: Should we silence the warning raised by I did consider disabling the warning by calling import platform
if platform.system() == 'Windows' and platform.architecture()[0].startswith('32'):
import warnings
warnings.simplefilter("ignore", category=UserWarning)
import cryptography.hazmat.bindings.openssl.bindingbut I think it is good to keep that warning to encourage people to upgrade to 64-bit Azure CLI once #26640 has been released. Additional information |
This was referenced Jun 14, 2023
bebound
previously approved these changes
Jun 29, 2023
jiasli
commented
Jun 29, 2023
| @@ -1,5 +1,8 @@ | |||
| pushd %~dp0..\.. | |||
|
|
|||
| Rem Upgrade pip to the latest version | |||
| python -m pip install --upgrade pip | |||
There was a problem hiding this comment.
Upgrading pip makes VerifyWindowsRequirements, VerifyLinuxRequirements and VerifyDarwinRequirements have the same logic as other package building jobs, such as BuildDebPackages.
It can utilize the latest pip's error message to better find dependency resolution failures.
|
We have decided to keep the warning, as it is printed to please set Update: We finally decided to postpone the version bump on Windows until Windows 64-bit MSI has been released (#26640). |
wangzelin007
previously approved these changes
Jun 29, 2023
jsntcy
previously approved these changes
Jun 29, 2023
jiasli
dismissed stale reviews from jsntcy, wangzelin007, and bebound
via
482f3a4
bebound
approved these changes
Jun 29, 2023
wangzelin007
approved these changes
Jun 29, 2023
jsntcy
approved these changes
Jun 29, 2023
3 tasks
jiasli
changed the title
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework of #26596
As explained in #26596 (comment), only bumping
cryptographyis not enough.pyOpenSSLshould be bumped at the same time.Close #25913