Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging traceback for fatal errors #1064

Merged
merged 2 commits into from
Jun 30, 2022
Merged

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Jun 23, 2022

Description

Currently, the log messages do not contain any relevant traceback and exception details. Adding a new traceback info to be logged.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@vrdmr vrdmr force-pushed the vameru/add-traceback-for-fatal-errors branch from 8d00280 to cc1588f Compare June 23, 2022 06:02
@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #1064 (cc1588f) into dev (66fb7dd) will decrease coverage by 0.12%.
The diff coverage is 22.22%.

@@            Coverage Diff             @@
##              dev    #1064      +/-   ##
==========================================
- Coverage   83.58%   83.46%   -0.13%     
==========================================
  Files          33       33              
  Lines        1773     1778       +5     
  Branches      282      282              
==========================================
+ Hits         1482     1484       +2     
- Misses        227      230       +3     
  Partials       64       64              
Flag Coverage Δ
unittests 83.46% <22.22%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/dispatcher.py 89.12% <0.00%> (ø)
azure_functions_worker/main.py 0.00% <0.00%> (ø)
azure_functions_worker/logging.py 40.81% <40.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66fb7dd...cc1588f. Read the comment docs.

@vrdmr vrdmr merged commit f3ec8a9 into dev Jun 30, 2022
@vrdmr vrdmr deleted the vameru/add-traceback-for-fatal-errors branch June 30, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants