Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Tracebacks for Error Logger and SDK Update #1072

Merged
merged 2 commits into from
Jul 12, 2022

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Jul 11, 2022

Description

Making a #1064 equivalent change for v3.x branch.

Fixes #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1072 (bae9b94) into v3.x-dev (4528fdd) will decrease coverage by 50.22%.
The diff coverage is 20.00%.

@@              Coverage Diff              @@
##           v3.x-dev    #1072       +/-   ##
=============================================
- Coverage     82.51%   32.28%   -50.23%     
=============================================
  Files            33       33               
  Lines          1653     1657        +4     
  Branches        265      265               
=============================================
- Hits           1364      535      -829     
- Misses          224     1121      +897     
+ Partials         65        1       -64     
Flag Coverage Δ
unittests 32.28% <20.00%> (-50.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
azure_functions_worker/dispatcher.py 20.94% <0.00%> (-68.72%) ⬇️
azure_functions_worker/main.py 0.00% <0.00%> (ø)
azure_functions_worker/logging.py 36.73% <40.00%> (-4.18%) ⬇️
azure_functions_worker/functions.py 20.15% <0.00%> (-72.87%) ⬇️
azure_functions_worker/utils/tracing.py 31.81% <0.00%> (-68.19%) ⬇️
azure_functions_worker/utils/common.py 33.33% <0.00%> (-66.67%) ⬇️
azure_functions_worker/bindings/meta.py 25.30% <0.00%> (-57.84%) ⬇️
...s/shared_memory_data_transfer/shared_memory_map.py 28.57% <0.00%> (-55.36%) ⬇️
azure_functions_worker/extension.py 43.92% <0.00%> (-55.15%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4528fdd...bae9b94. Read the comment docs.

@vrdmr vrdmr merged commit e78e2e3 into v3.x-dev Jul 12, 2022
@vrdmr vrdmr deleted the vameru/logging-traceback-sdk-update branch July 12, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants