Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate iotcentral command group #166

Merged
merged 3 commits into from
Apr 22, 2020

Conversation

r-delgadillo
Copy link
Contributor

@r-delgadillo r-delgadillo commented Apr 21, 2020


This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact [email protected] with any additional questions or comments.

Thank you for contributing to the IoT extension!

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • If introducing new functionality or modified behavior, are they backed by unit and integration tests?
  • In the same context as above are command names and their parameter definitions accurate? Do help docs have sufficient content?
  • Have all unit and integration tests passed locally? i.e. pytest <project root> -vv
  • Have static checks passed using the .pylintrc and .flake8 rules? Look at the CI scripts for example usage.

@r-delgadillo r-delgadillo requested a review from digimaun as a code owner April 21, 2020 16:48
@r-delgadillo
Copy link
Contributor Author

Command group 'az iotcentral' has been deprecated on the Azure CLI. Deprecating the same command group in extension.

PR for Azure CLI
https://github.com/Azure/azure-cli/blob/dev/src/azure-cli/HISTORY.rst

deprecate_info=self.deprecate(redirect='iot central', hide=True)
) as cmd_group:
pass

with self.command_group("iotcentral app", command_type=iotcentral_ops) as cmd_group:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this iotcentral app too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to leave the command there for at least 3 months before removing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR will mark anything under az iotcentral as deprecated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible we should. Also the deprecated iotcentral device-twin command group. @r-delgadillo is there a reason they are still around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a work item in our backlog to completely remove all commands under az iotcentral in June or July, I forgot which month specifically. We'd like to keep these commands available for customers who are using them to give them sufficient time for them to roll off these commands and start using the new command group. Hence that's the reason we are hiding the existing command group so no other customers become aware of those commands.

@digimaun digimaun merged commit 1686c7f into Azure:dev Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants