Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate iotcentral command group #166

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Deprecate iotcentral command group #166

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f825020
Deprecate iot central
Apr 21, 2020
09f6cb3
remove white space
Apr 21, 2020
225a7a0
Merge branch 'dev' into rodelga/central/deprecate
digimaun Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions azext_iot/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,11 +164,16 @@ def load_command_table(self, _):
cmd_group.command("show", "iot_dps_registration_get")
cmd_group.command("delete", "iot_dps_registration_delete")

with self.command_group(
'iotcentral', command_type=iotcentral_ops,
deprecate_info=self.deprecate(redirect='iot central', hide=True)
) as cmd_group:
pass

with self.command_group("iotcentral app", command_type=iotcentral_ops) as cmd_group:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we remove this iotcentral app too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to leave the command there for at least 3 months before removing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR will mark anything under az iotcentral as deprecated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible we should. Also the deprecated iotcentral device-twin command group. @r-delgadillo is there a reason they are still around?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a work item in our backlog to completely remove all commands under az iotcentral in June or July, I forgot which month specifically. We'd like to keep these commands available for customers who are using them to give them sufficient time for them to roll off these commands and start using the new command group. Hence that's the reason we are hiding the existing command group so no other customers become aware of those commands.

cmd_group.command(
"monitor-events",
"iot_central_monitor_events",
deprecate_info="az iot central app monitor-events",
)

with self.command_group(
Expand All @@ -177,7 +182,6 @@ def load_command_table(self, _):
cmd_group.command(
"show",
"iot_central_device_show",
deprecate_info="az iot central device-twin",
)

with self.command_group(
Expand Down