Update provisioning tests to retry on throttling #2411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
azabbasi,
andyk-ms,
brycewang-microsoft and
tmahmood-microsoft
as code owners
abhipsaMisra
force-pushed
the
abmisr/provRetry
branch
from
f644710 to
f6f1a09
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Do we need this for creating enrollment groups as well? Or do we not create enough of them to warrant adding retry to them? |
timtay-microsoft
approved these changes
May 24, 2022
Right now, we don't create as many enrollment groups as we create individual enrollments. That said, I'm working on creating X509 based enrollment groups on-demand as well. With that change I'll be adding the retry policies to enrollment groups as well. |
abhipsaMisra
force-pushed
the
abmisr/provRetry
branch
from
43121ac to
4b36d42
Compare
This reverts commit 4b36d42.
abhipsaMisra
commented
May 24, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
pushed a commit
that referenced
this pull request
Jun 2, 2022
* refactor(e2e-tests): Update provisioning tests to retry on throttling (#2411) * refactor(e2e-tests): Update reprovisioning tests to retry on throttling * refactor(iot-device): Add additional logging statement to disposal flow (#2414) * fix(iot-device): Fix twin operations with Mqtt to retry on throttling (#2416) * Add documentation about HttpClient and socket exhaustion to service clients (#2423) Co-authored-by: Abhipsa Misra <[email protected]> Co-authored-by: brycewang-microsoft <[email protected]>
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the biggest pain points while working on the feature for DPS client certs was our E2E test limitation of reusing the same enrollment entry for X509 certificate-based enrollments. Once I modified the tests to generate X509 certificate-based enrollments on-demand, our DPS infrastructure was unable to handle the volume of requests it was receiving from our E2E tests to create enrollments. As a result, most of our tests kept on getting throttled and would subsequently fail.
This PR adds retry logic for provisioning service client failures with error codes 429 (throttling) and 5xx (server errors).