refactor(iot-device): Add additional logging statement to disposal flow #2414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
abhipsaMisra
commented
May 25, 2022
abhipsaMisra
commented
abhipsaMisra
force-pushed
the
abmisr/disposeLogs
branch
from
bcc3aaa to
bf5b699
Compare
abhipsaMisra
commented
May 25, 2022
abhipsaMisra
commented
May 25, 2022
abhipsaMisra
commented
May 25, 2022
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
azabbasi,
andyk-ms,
brycewang-microsoft and
tmahmood-microsoft
as code owners
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timtay-microsoft
approved these changes
May 25, 2022
abhipsaMisra
force-pushed
the
abmisr/disposeLogs
branch
from
b3d5c8b to
f41e286
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
reviewed
May 31, 2022
| } | ||
| if (Logging.IsEnabled) | ||
| { | ||
| Logging.Enter(this, $"{nameof(DefaultDelegatingHandler)}.Disposed={_disposed}; disposing={disposing}", $"{nameof(TransportHandler)}.{nameof(Dispose)}"); |
There was a problem hiding this comment.
Why DefaultDelegatingHandler?
There was a problem hiding this comment.
The _disposed parameter referenced throughout our delegating handler pipeline is actually the protected variable defined in DefaultDelegatingHandler:
This, along with the way base.Dispose() and inherited.Dispose() are mixed in our pipeline disposal flow is something I'm looking to refactor.
drwill-ms
pushed a commit
that referenced
this pull request
Jun 2, 2022
* refactor(e2e-tests): Update provisioning tests to retry on throttling (#2411) * refactor(e2e-tests): Update reprovisioning tests to retry on throttling * refactor(iot-device): Add additional logging statement to disposal flow (#2414) * fix(iot-device): Fix twin operations with Mqtt to retry on throttling (#2416) * Add documentation about HttpClient and socket exhaustion to service clients (#2423) Co-authored-by: Abhipsa Misra <[email protected]> Co-authored-by: brycewang-microsoft <[email protected]>
timstewartm
pushed a commit
to timstewartm/azure-iot-sdk-csharp
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.