Fix namespaces #2871
Merged
Fix namespaces #2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
abhipsaMisra
commented
Oct 14, 2022
| @@ -1,7 +1,7 @@ | |||
| // Copyright (c) Microsoft. All rights reserved. | |||
| // Licensed under the MIT license. See LICENSE file in the project root for full license information. | |||
|
|
|||
| namespace Microsoft.Azure.Devices.Client.Transport.Mqtt | |||
| namespace Microsoft.Azure.Devices.Client | |||
There was a problem hiding this comment.
The amqp public types are under the "root" namespace, so moving this there as well
abhipsaMisra
commented
Oct 14, 2022
| @@ -3,7 +3,7 @@ | |||
|
|
|||
| using Newtonsoft.Json; | |||
|
|
|||
| namespace Microsoft.Azure.Devices.Client.Transport | |||
| namespace Microsoft.Azure.Devices.Client | |||
There was a problem hiding this comment.
This, and below - they aren't transport specific types really.
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
drwill-ms
approved these changes
Oct 14, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tmahmood-microsoft
approved these changes
Oct 14, 2022
andyk-ms
approved these changes
Oct 14, 2022
patilsnr
approved these changes
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These public types don't require their own namespaces