Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix namespaces #2871

Merged
merged 3 commits into from
Oct 14, 2022
Merged

Fix namespaces #2871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6051aca
Fix namespaces
abhipsaMisra Oct 14, 2022
3ed9801
Remove unused usings
abhipsaMisra Oct 14, 2022
e2204be
unit test fix
abhipsaMisra Oct 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion iothub/device/src/FileUpload/FileUploadCompletionNotification.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

using Newtonsoft.Json;

namespace Microsoft.Azure.Devices.Client.Transport
namespace Microsoft.Azure.Devices.Client
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This, and below - they aren't transport specific types really.

{
/// <summary>
/// The request payload to send to IoT hub to notify it when a file upload is completed, whether successful or not.
Expand Down
2 changes: 1 addition & 1 deletion iothub/device/src/FileUpload/FileUploadSasUriRequest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

using Newtonsoft.Json;

namespace Microsoft.Azure.Devices.Client.Transport
namespace Microsoft.Azure.Devices.Client
{
/// <summary>
/// The request parameters when getting a file upload SAS URI from IoT hub.
Expand Down
2 changes: 1 addition & 1 deletion iothub/device/src/FileUpload/FileUploadSasUriResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
using System.Globalization;
using Newtonsoft.Json;

namespace Microsoft.Azure.Devices.Client.Transport
namespace Microsoft.Azure.Devices.Client
{
/// <summary>
/// The information provided from IoT hub that can be used with the Azure Storage SDK
Expand Down
1 change: 0 additions & 1 deletion iothub/device/src/IotHubDeviceClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
using System;
using System.Threading;
using System.Threading.Tasks;
using Azure.Core;
using Microsoft.Azure.Devices.Client.Transport;

namespace Microsoft.Azure.Devices.Client
Expand Down
2 changes: 1 addition & 1 deletion iothub/device/src/Transport/Http/IETagHolder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

namespace Microsoft.Azure.Devices.Client.Transport
namespace Microsoft.Azure.Devices.Client
{
/// <summary>
/// ETag Holder Interface
Expand Down
2 changes: 1 addition & 1 deletion iothub/device/src/Transport/Mqtt/IWillMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

namespace Microsoft.Azure.Devices.Client.Transport.Mqtt
namespace Microsoft.Azure.Devices.Client
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The amqp public types are under the "root" namespace, so moving this there as well

{
/// <summary>
/// An MQTT "will" message to be sent by this client before the client disconnects.
Expand Down
2 changes: 1 addition & 1 deletion iothub/device/src/Transport/Mqtt/WillMessage.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.

namespace Microsoft.Azure.Devices.Client.Transport.Mqtt
namespace Microsoft.Azure.Devices.Client
{
/// <summary>
/// An MQTT "will" message to be sent by this client before the client disconnects.
Expand Down
1 change: 0 additions & 1 deletion iothub/device/src/TransportSettings/IotHubClientMqttSettings.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

using System;
using System.Net.Security;
using Microsoft.Azure.Devices.Client.Transport.Mqtt;

namespace Microsoft.Azure.Devices.Client
{
Expand Down
2 changes: 1 addition & 1 deletion iothub/device/tests/Pipeline/RetryDelegatingHandlerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ public async Task RetrySetRetryPolicyVerifyInternalsSuccess()

int nextHandlerCallCounter = 0;

nextHandlerMock.OpenAsync(Arg.Any<CancellationToken>()).Returns(t =>
nextHandlerMock.OpenAsync(CancellationToken.None).Returns(t =>
{
nextHandlerCallCounter++;
throw new IotHubClientException(IotHubClientErrorCode.NetworkErrors);
Expand Down