Fix build errors in previews/v2 #3024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
* Change param name to not be a reserved keyword * Cleanup * Update to match ModulesClient
* Specify IFormatProvider * Change to InvariantCulture to stay consistent with track 2 SDKs
* Change Parameter names to match base declaration * Fix error CA1854, Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup * Change Parameter names to match base declaration * Fix error CA1854, Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup * More string IFormatProvider fixes * Cleanup
* Fix IDisposable errors * Fix Dispose implementation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
schoims
approved these changes
Dec 16, 2022
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
timtay-microsoft
approved these changes
Dec 16, 2022
ngastelum-ms
approved these changes
Dec 16, 2022
Co-authored-by: ngastelum-ms <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Fix param name matching in base class method and derived class overridden method- Part 1 of build error fixes #3023String comparison errors -> String.Format, String.Equals, String.StartsWith... etc- Fix StringComparison Errors #3031using reserved keywordFix reserved keyword error #3025Add missing constructors to exception classesAdd missing constructors to exception classes #3026CA1010: Collections should implement generic interfaceCollections should implement generic interface #3028CA2201: Exception type System.Exception is not sufficiently specificThrow InvalidOperationException instead of System.Exception #3029CA1822: Mark members as staticMark members as static #3032