Add missing constructors to exception classes #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhipsaMisra
requested review from
drwill-ms,
timtay-microsoft,
andyk-ms,
brycewang-microsoft,
tmahmood-microsoft,
ngastelum-ms and
patilsnr
as code owners
tmahmood-microsoft
approved these changes
Dec 14, 2022
ngastelum-ms
approved these changes
Dec 14, 2022
abhipsaMisra
added a commit
that referenced
this pull request
Dec 16, 2022
* Fix param name matching in base class method and derived class overridden method (#3023) * Fix reserved keyword error (#3025) * Change param name to not be a reserved keyword * Cleanup * Update to match ModulesClient * Add missing constructors to exception classes (#3026) * Fix for Specify IFormatProvider errors (#3027) * Specify IFormatProvider * Change to InvariantCulture to stay consistent with track 2 SDKs * Throw InvalidOperationException instead of System.Exception (#3029) * Assign the instance to a variable (#3030) * Collections should implement generic interface (#3028) * Fix StringComparison Errors (#3031) * Mark members as static (#3032) * Fix param name matching in base class method and derived class overridden method (#3033) * More build fixes (#3034) * Change Parameter names to match base declaration * Fix error CA1854, Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup * Change Parameter names to match base declaration * Fix error CA1854, Prefer a 'TryGetValue' call over a Dictionary indexer access guarded by a 'ContainsKey' check to avoid double lookup * More string IFormatProvider fixes * Cleanup * IDisposable fixes (#3035) * Fix IDisposable errors * Fix Dispose implementation * Use Array.Empty instead of zero lenth arrays, static methods for tests (#3037) * Simplify access * Update iothub/device/tests/Transport/Amqp/AmqpConnectionPoolTests.cs Co-authored-by: ngastelum-ms <[email protected]> Co-authored-by: ngastelum-ms <[email protected]>
abhipsaMisra
added a commit
that referenced
this pull request
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom exceptions should be serializable so that the exception information can be serialized and shared between different services/processes.
CA2229: Implement serialization constructors