Route 2025-01-01 #31929
Open
Route 2025-01-01 #31929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
koyasu221b
added
PublishToCustomers
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
koyasu221b
force-pushed
the
users/huangwill/koyasu221b-maps-Route-2025-01-01
branch
2 times, most recently
from
fd1fb67 to
287212f
Compare
koyasu221b
requested review from
JeffreyRichter,
johanste,
mikekistler and
FarazGIS
and removed request for
a team
koyasu221b
force-pushed
the
users/huangwill/koyasu221b-maps-Route-2025-01-01
branch
2 times, most recently
from
6e965d8 to
aaf533e
Compare
koyasu221b
added
the
DoNotMerge
FarazGIS
reviewed
Jan 24, 2025
FarazGIS
approved these changes
Jan 24, 2025
koyasu221b
force-pushed
the
users/huangwill/koyasu221b-maps-Route-2025-01-01
branch
from
8d45243 to
4bd50f3
Compare
mikekistler
requested changes
Jan 25, 2025
specification/maps/data-plane/Route/stable/2025-01-01/route.json
Outdated
Show resolved
Hide resolved
specification/maps/data-plane/Route/stable/2025-01-01/route.json
Outdated
Show resolved
Hide resolved
specification/maps/data-plane/Route/stable/2025-01-01/route.json
Outdated
Show resolved
Hide resolved
| "trafficCongestion": { | ||
| "$ref": "#/definitions/TrafficCongestionEnum" | ||
| }, | ||
| "departureTime": { |
There was a problem hiding this comment.
DateTime properties do not seem to have any coherent naming convention.
- DirectionsRequest and RouteMatrixRequest have date-time properties
departAtandarriveAt - InputRouteRangeProperties has
departAt - RoutePathProperties, Leg, and RouteMatrixItemResult have date-time properties
departureTimeandarrivalTime - RouteOperation has
createdDateTimeandlastActionDateTime
Date-time properties should use a consistent naming convention. The suffix for all these should either be "At" (recommended) or "Time" or "DateTime". Pick one and use it everywhere.
|
@stevemunk @pbrasil Sharing the Route PR as we will publishing the swagger docs in the next few weeks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Plane API Specification Update Pull Request
Based on the previous Route Preview API (2024-07-24-preview), the following updates have been added:
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
API Info: The Basics
Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.
Is this review for (select one):
Change Scope
This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.
/route/directions,/route:rangeViewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.