[NetAppFiles]Anf 22712 update for 2022 09 01 #21606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into ANF-22712-Update-For-2022-09-01
|
Hi, @audunn Thanks for your PR. I am workflow bot for review process. Here are some small tips. Any feedback about review process or workflow bot, pls contact swagger and tools team. [email protected] |
Swagger Validation Report
|
| compared swaggers (via Oad v0.10.4)] | new version | base version |
|---|---|---|
| netapp.json | 2022-09-01(33900a4) | 2022-05-01(main) |
| netapp.json | 2022-09-01(33900a4) | 2021-04-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 24 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 24 items are listed, please refer to log for more details.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 3 Warnings warning [Detail]
| compared tags (via openapi-validator v2.0.0) | new version | base version |
|---|---|---|
| package-netapp-2022-09-01 | package-netapp-2022-09-01(33900a4) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L5959 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L6172 |
||
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L6875 |
The following errors/warnings exist before current PR submission:
Only 24 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The response schema of operations API '/providers/Microsoft.NetApp/operations' does not match the ARM specification. Please standardize the schema. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L59 |
|
The resource name parameter 'quotaLimitName' should be defined with a 'pattern' restriction. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L255 |
|
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L530 |
|
The patch operation body parameter schema should contains property 'identity'. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L558 |
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L558 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L558 |
|
The patch operation body parameter schema should not contains property location. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L558 |
|
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L587 |
|
An async POST operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'location' on 'x-ms-long-running-operation-options' Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L612 |
|
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L637 |
|
An async PUT operation is tracked via Azure-AsyncOperation header. Set 'final-state-via' property to 'azure-async-operation' on 'x-ms-long-running-operation-options' Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L740 |
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L808 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L808 |
|
The patch operation body parameter schema should not contains property location. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L808 |
|
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L840 |
|
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L882 |
|
Only 201 is the supported response code for PUT async response. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L1043 |
|
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L1043 |
|
The patch operation body parameter schema should not contains property name. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L1068 |
|
The patch operation body parameter schema should not contains property type. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L1068 |
|
The patch operation body parameter schema should not contains property location. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L1068 |
|
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L1103 |
|
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L1158 |
|
A 202 response should include an Location response header. Location: Microsoft.NetApp/stable/2022-09-01/netapp.json#L1220 |
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.NetApp/netAppAccounts/{}/vaults is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/netapp/resource-manager/readme.md json: Microsoft.NetApp/stable/2022-05-01/netapp.json |
️️✔️ApiReadinessCheck succeeded [Detail] [Expand]
️❌~[Staging] ServiceAPIReadinessTest: 41 Errors, 0 Warnings failed [Detail]
Tag package-netapp-2022-09-01; Prod region: Deployed
Test run on region: northcentralus; Operation coverage: total: 82, untested: 0, failed: 41, passed: 41
Service API Readiness Test failed. Check pipeline artifact for detail report.
Only 24 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
statusCode: 400, errorCode: MsiInvalidForRenewal, errorMessage: NetApp account does not have an MSI credentials, therefore it is ineligible for renewal of credentials. Source: runtime OperationId: Accounts_RenewCredentials |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_ReplicationStatus |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_BreakFileLocks |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_FinalizeRelocation |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_RevertRelocation |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_Revert |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_ReInitializeReplication |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_AuthorizeReplication |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_ResyncReplication |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_ResetCifsPassword |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_Relocate |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_ListReplications |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_ReestablishReplication |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Volumes_PoolChange |
|
statusCode: 400, errorCode: BadRequest, errorMessage: Volume was not found or was not created successfully. Source: runtime OperationId: Snapshots_Create |
|
statusCode: 404, errorCode: NotFound, errorMessage: The volume 'volumenajw7iwi' was not found. Please make sure you have the correct URI and that the volume exists. Source: runtime OperationId: Snapshots_Get |
|
statusCode: 405, errorCode: PatchOperationNotSupported, errorMessage: Patch operation is not supported for this resource type. Source: runtime OperationId: Snapshots_Update |
|
statusCode: 400, errorCode: BadRequest, errorMessage: Volume was not found or was not created successfully. Source: runtime OperationId: Subvolumes_Create |
|
statusCode: 404, errorCode: NotFound, errorMessage: The volume 'volumenajw7iwi' was not found. Please make sure you have the correct URI and that the volume exists. Source: runtime OperationId: Subvolumes_Get |
|
statusCode: 409, errorCode: Conflict, errorMessage: Operation: 'Microsoft.NetApp/netAppAccounts/capacityPools/volumes/subvolumes' is not permitted. Source: runtime OperationId: Subvolumes_Update |
|
statusCode: 404, errorCode: NotFound, errorMessage: Volume was not found or was not created successfully. Source: runtime OperationId: Subvolumes_GetMetadata |
|
statusCode: 400, errorCode: BadRequest, errorMessage: The volume 'backupna883ael' was not found. Please make sure you have the correct URI and that the volume exists. Source: runtime OperationId: Backups_Create |
|
statusCode: 412, errorCode: ParentEntityMissingOrNotCreatedSuccessfully, errorMessage: Unable to complete the operation. Please verify that the parent volume 'volumenajw7iwi' exists and that it is in a 'Succeeded' state and try again. Source: runtime OperationId: Backups_GetStatus |
|
statusCode: 404, errorCode: NotFound, errorMessage: The volume 'volumenajw7iwi' was not found. Please make sure you have the correct URI and that the volume exists. Source: runtime OperationId: Backups_Get |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️CadlAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️PrettierCheck succeeded [Detail] [Expand]
Validation passes for PrettierCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️CadlValidation succeeded [Detail] [Expand]
Validation passes for CadlValidation.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
Swagger Generation Artifacts
|
| Rule | Message |
|---|---|
|
"logUrl":"https://apidrop.visualstudio.com/Content%20CI/_build/results?buildId=347905&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b", "detail":"Unable to load the service index for source https://apidrop.pkgs.visualstudio.com/_packaging/ReferenceAutomationTool/nuget/v3/index.json." |
️❌SDK Breaking Change Tracking failed [Detail]
Breaking Changes Tracking
❌azure-sdk-for-go - sdk/resourcemanager/netapp/armnetapp - 4.0.0+ Field `VaultID` of struct `VolumeBackupProperties` has been removed + Function `*VaultsClient.NewListPager` has been removed + Function `NewVaultsClient` has been removed + Struct `Identity` has been removed + Struct `VaultList` has been removed + Struct `VaultProperties` has been removed + Struct `Vault` has been removed + Struct `VaultsClient` has been removed + Type alias `IdentityType` has been removed + Type of `Account.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity`
❌azure-sdk-for-python-track2 - track2_azure-mgmt-netapp - 9.0.2b1+ Model VolumeBackupProperties no longer has parameter vault_id + Model VolumeRelocationProperties no longer has parameter old_bare_metal_tenant_id + Model VolumeRelocationProperties no longer has parameter old_volume_id + Parameter location of model BackupPolicyDetails is now required + Removed operation group VaultsOperations
❌azure-sdk-for-js - @azure/arm-netapp - 18.0.0+ Class NetAppManagementClient no longer has parameter vaults + Interface Backup no longer has parameter id + Interface Backup no longer has parameter name + Interface Backup no longer has parameter type + Interface BackupPolicyDetails no longer has parameter id + Interface BackupPolicyDetails no longer has parameter name + Interface BackupPolicyDetails no longer has parameter type + Interface Snapshot no longer has parameter id + Interface Snapshot no longer has parameter name + Interface Snapshot no longer has parameter type + Interface VolumeBackupProperties no longer has parameter vaultId + Interface VolumeRelocationProperties no longer has parameter oldBareMetalTenantId + Interface VolumeRelocationProperties no longer has parameter oldVolumeId + Removed Enum KnownIdentityType + Removed operation group Vaults + Type of parameter identity of interface NetAppAccount is changed from Identity to ManagedServiceIdentity
️⚠️ azure-sdk-for-python-track2 warning [Detail]
command sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json cmderr [automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed. command sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json cmderr [automation_generate.sh] cmderr [automation_generate.sh] npm notice New major version of npm available! 8.19.3 -> 9.5.0 cmderr [automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.5.0> cmderr [automation_generate.sh] npm notice Run `npm install -g [email protected]` to update! cmderr [automation_generate.sh] npm notice
️✔️track2_azure-mgmt-netapp [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Features Added info [Changelog] info [Changelog] - Added operation BackupsOperations.begin_restore_files info [Changelog] - Added operation VolumesOperations.begin_break_file_locks info [Changelog] - Model ActiveDirectory has a new parameter preferred_servers_for_ldap_client info [Changelog] - Model Backup has a new parameter system_data info [Changelog] - Model BackupPolicyDetails has a new parameter system_data info [Changelog] - Model Snapshot has a new parameter system_data info [Changelog] - Model Volume has a new parameter data_store_resource_id info [Changelog] - Model Volume has a new parameter file_access_logs info [Changelog] - Model Volume has a new parameter is_large_volume info [Changelog] - Model Volume has a new parameter provisioned_availability_zone info [Changelog] - Model VolumeGroupVolumeProperties has a new parameter data_store_resource_id info [Changelog] - Model VolumeGroupVolumeProperties has a new parameter file_access_logs info [Changelog] - Model VolumeGroupVolumeProperties has a new parameter is_large_volume info [Changelog] - Model VolumeGroupVolumeProperties has a new parameter provisioned_availability_zone info [Changelog] - Model VolumePropertiesDataProtection has a new parameter volume_relocation info [Changelog] - Model VolumeQuotaRulePatch has a new parameter tags info [Changelog] - Model VolumeRelocationProperties has a new parameter ready_to_be_finalized info [Changelog] info [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Model VolumeBackupProperties no longer has parameter vault_id info [Changelog] - Model VolumeRelocationProperties no longer has parameter old_bare_metal_tenant_id info [Changelog] - Model VolumeRelocationProperties no longer has parameter old_volume_id info [Changelog] - Parameter location of model BackupPolicyDetails is now required info [Changelog] - Removed operation group VaultsOperations
️❌ azure-sdk-for-net-track2 failed [Detail]
command pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json command pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:672 cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1mLine | cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m 672 | �[0m �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m … cmderr [Invoke-GenerateAndBuildV2.ps1] �[36;1m | �[31;1m ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ cmderr [Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m | �[31;1mFailed to build sdk. exit code: False cmderr [Invoke-GenerateAndBuildV2.ps1] �[0m
❌Azure.ResourceManager.NetApp [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] Breaking Changes: /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : TypesMustExist : Type 'Azure.ResourceManager.NetApp.Models.NetAppVault' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/netapp/Azure.ResourceManager.NetApp/src/Azure.ResourceManager.NetApp.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public Azure.Core.ResourceIdentifier Azure.ResourceManager.NetApp.Models.NetAppVolumeBackupConfiguration.VaultId.get()' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/netapp/Azure.ResourceManager.NetApp/src/Azure.ResourceManager.NetApp.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(82,5): error : MembersMustExist : Member 'public void Azure.ResourceManager.NetApp.Models.NetAppVolumeBackupConfiguration.VaultId.set(Azure.Core.ResourceIdentifier)' does not exist in the implementation but it does exist in the contract. [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/netapp/Azure.ResourceManager.NetApp/src/Azure.ResourceManager.NetApp.csproj::TargetFramework=netstandard2.0], info [Changelog] /home/cloudtest/.nuget/packages/microsoft.dotnet.apicompat/5.0.0-beta.20467.1/build/Microsoft.DotNet.ApiCompat.targets(96,5): error : ApiCompat failed for '/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/bin/Azure.ResourceManager.NetApp/Debug/netstandard2.0/Azure.ResourceManager.NetApp.dll' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/netapp/Azure.ResourceManager.NetApp/src/Azure.ResourceManager.NetApp.csproj::TargetFramework=netstandard2.0]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
command sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json warn File azure-sdk-for-js_tmp/initOutput.json not found to read command sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
️✔️@azure/arm-netapp [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] **Features** info [Changelog] info [Changelog] - Added operation Backups.beginRestoreFiles info [Changelog] - Added operation Backups.beginRestoreFilesAndWait info [Changelog] - Added operation Volumes.beginBreakFileLocks info [Changelog] - Added operation Volumes.beginBreakFileLocksAndWait info [Changelog] - Added Interface BackupRestoreFiles info [Changelog] - Added Interface BackupsRestoreFilesHeaders info [Changelog] - Added Interface BackupsRestoreFilesOptionalParams info [Changelog] - Added Interface BreakFileLocksRequest info [Changelog] - Added Interface ManagedServiceIdentity info [Changelog] - Added Interface VolumesBreakFileLocksHeaders info [Changelog] - Added Interface VolumesBreakFileLocksOptionalParams info [Changelog] - Added Type Alias FileAccessLogs info [Changelog] - Added Type Alias ManagedServiceIdentityType info [Changelog] - Interface ActiveDirectory has a new optional parameter preferredServersForLdapClient info [Changelog] - Interface Volume has a new optional parameter dataStoreResourceId info [Changelog] - Interface Volume has a new optional parameter fileAccessLogs info [Changelog] - Interface Volume has a new optional parameter isLargeVolume info [Changelog] - Interface Volume has a new optional parameter provisionedAvailabilityZone info [Changelog] - Interface VolumeGroupVolumeProperties has a new optional parameter dataStoreResourceId info [Changelog] - Interface VolumeGroupVolumeProperties has a new optional parameter fileAccessLogs info [Changelog] - Interface VolumeGroupVolumeProperties has a new optional parameter isLargeVolume info [Changelog] - Interface VolumeGroupVolumeProperties has a new optional parameter provisionedAvailabilityZone info [Changelog] - Interface VolumePropertiesDataProtection has a new optional parameter volumeRelocation info [Changelog] - Interface VolumeQuotaRulePatch has a new optional parameter tags info [Changelog] - Interface VolumeRelocationProperties has a new optional parameter readyToBeFinalized info [Changelog] - Added Enum KnownFileAccessLogs info [Changelog] - Added Enum KnownManagedServiceIdentityType info [Changelog] info [Changelog] **Breaking Changes** info [Changelog] info [Changelog] - Removed operation group Vaults info [Changelog] - Operation NetAppResource.checkNameAvailability has a new signature info [Changelog] - Operation NetAppResource.checkQuotaAvailability has a new signature info [Changelog] - Interface Backup no longer has parameter id info [Changelog] - Interface Backup no longer has parameter name info [Changelog] - Interface Backup no longer has parameter type info [Changelog] - Interface BackupPolicyDetails no longer has parameter id info [Changelog] - Interface BackupPolicyDetails no longer has parameter name info [Changelog] - Interface BackupPolicyDetails no longer has parameter type info [Changelog] - Interface Snapshot no longer has parameter id info [Changelog] - Interface Snapshot no longer has parameter name info [Changelog] - Interface Snapshot no longer has parameter type info [Changelog] - Interface VolumeBackupProperties no longer has parameter vaultId info [Changelog] - Interface VolumeRelocationProperties no longer has parameter oldBareMetalTenantId info [Changelog] - Interface VolumeRelocationProperties no longer has parameter oldVolumeId info [Changelog] - Type of parameter identity of interface NetAppAccount is changed from Identity to ManagedServiceIdentity info [Changelog] - Class NetAppManagementClient no longer has parameter vaults info [Changelog] - Removed Enum KnownIdentityType
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
command sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json command generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
️✔️sdk/resourcemanager/netapp/armnetapp [View full logs] [Release SDK Changes] Breaking Change Detectedinfo [Changelog] ### Breaking Changes info [Changelog] info [Changelog] - Function `*SnapshotsClient.BeginUpdate` parameter(s) have been changed from `(context.Context, string, string, string, string, string, interface{}, *SnapshotsClientBeginUpdateOptions)` to `(context.Context, string, string, string, string, string, any, *SnapshotsClientBeginUpdateOptions)` info [Changelog] - Type of `Account.Identity` has been changed from `*Identity` to `*ManagedServiceIdentity` info [Changelog] - Type alias `IdentityType` has been removed info [Changelog] - Function `NewVaultsClient` has been removed info [Changelog] - Function `*VaultsClient.NewListPager` has been removed info [Changelog] - Struct `Identity` has been removed info [Changelog] - Struct `Vault` has been removed info [Changelog] - Struct `VaultList` has been removed info [Changelog] - Struct `VaultProperties` has been removed info [Changelog] - Struct `VaultsClient` has been removed info [Changelog] - Field `VaultID` of struct `VolumeBackupProperties` has been removed info [Changelog] info [Changelog] ### Features Added info [Changelog] info [Changelog] - New type alias `FileAccessLogs` with values `FileAccessLogsDisabled`, `FileAccessLogsEnabled` info [Changelog] - New type alias `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned` info [Changelog] - New function `*BackupsClient.BeginRestoreFiles(context.Context, string, string, string, string, string, BackupRestoreFiles, *BackupsClientBeginRestoreFilesOptions) (*runtime.Poller[BackupsClientRestoreFilesResponse], error)` info [Changelog] - New function `*VolumesClient.BeginBreakFileLocks(context.Context, string, string, string, string, *VolumesClientBeginBreakFileLocksOptions) (*runtime.Poller[VolumesClientBreakFileLocksResponse], error)` info [Changelog] - New struct `BackupRestoreFiles` info [Changelog] - New struct `BreakFileLocksRequest` info [Changelog] - New struct `ManagedServiceIdentity` info [Changelog] - New struct `VolumeRelocationProperties` info [Changelog] - New field `PreferredServersForLdapClient` in struct `ActiveDirectory` info [Changelog] - New field `SystemData` in struct `Backup` info [Changelog] - New field `SystemData` in struct `Snapshot` info [Changelog] - New field `DataStoreResourceID` in struct `VolumeProperties` info [Changelog] - New field `FileAccessLogs` in struct `VolumeProperties` info [Changelog] - New field `IsLargeVolume` in struct `VolumeProperties` info [Changelog] - New field `ProvisionedAvailabilityZone` in struct `VolumeProperties` info [Changelog] - New field `VolumeRelocation` in struct `VolumePropertiesDataProtection` info [Changelog] - New field `Tags` in struct `VolumeQuotaRulePatch` info [Changelog] info [Changelog] Total 16 breaking change(s), 24 additive change(s).
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
command ./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json command ./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
️✔️azure-resourcemanager-netapp [View full logs] [Release SDK Changes]
️⚠️ azure-resource-manager-schemas warning [Detail]
command .sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json cmderr [initScript.sh] WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile The package-lock.json file was created with an old version of npm, cmderr [initScript.sh] npm WARN old lockfile so supplemental metadata must be fetched from the registry. cmderr [initScript.sh] npm WARN old lockfile cmderr [initScript.sh] npm WARN old lockfile This is a one-time fix-up, please be patient... cmderr [initScript.sh] npm WARN old lockfile warn File azure-resource-manager-schemas_tmp/initOutput.json not found to read command .sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
️✔️netapp [View full logs] [Release Schema Changes]
️❌ azure-powershell failed [Detail]
command sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json command pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
❌Az.netapp [View full logs] [Release SDK Changes]
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
BreakingChangeReviewRequired
|
Hi, @audunn, For review efficiency consideration, when creating a new api version, it is required to place API specs of the base version in the first commit, and push new version updates into successive commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki. Or you could onboard API spec pipeline |
|
Hi @audunn, one or multiple breaking change(s) is detected in your PR. Please check out the breaking change(s), and provide business justification in the PR comment and @ PR assignee why you must have these change(s), and how external customer impact can be mitigated. Please ensure to follow breaking change policy to request breaking change review and approval before proceeding swagger PR review. |
|
Hi @audunn, Your PR has some issues. Please fix the CI sequentially by following the order of
|
This was referenced Nov 18, 2022
Closed
@audunn There's a MISSING_APIS_IN_DEFAULT_TAG error in Avocado. Is this by intention? |
Yes, the breaking change was approved by Breaking change review board |
leniatgh
added
Approved-Avocado
ReadyForApiTest
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@leni-msft ApiReadinessCheck passed, are we ready to move on with this now or is there more to be done here ? |
|
@audunn Thanks, good to know the ApiReadinessCheck passed - so the new api-version has been deployed. |
|
@leni-msft Is this a new requrement we must complete now? I dont think we have had do to this with previous updates. |
|
@audunn Yes, this is a new CI check (in staging), so not required as of now. |
This was referenced Feb 22, 2023
aviyerMSFT
pushed a commit
to aviyerMSFT/azure-rest-api-specs
that referenced
this pull request
Mar 22, 2023
* Add 2022-09-01 folder * update apiv-version number * Update VG example * update 2022-09-01 * ci fix * review fixes refrence common types * reivew- use identity from common types * reivew- use identity from common types2 * pretty * updated description for restoreFilePath * use common types, remove lastTransferDuration from this version * typy, remove requred locations from backups * Fix some examples * Improve some examples * Remove not needed identity * Remove x-nullable * identity common * OperationsResult * revert older change * revert older change * revert older change * QuotaRule Patch add missing tags * s360 Add missing fileAccessLogs property * Useraccount, description and fix one example * Revert changes to prev api-versions * No longer refernce common types for voluemQuotaRule patch, it causes error due to unsupported parameter name * Add location for SDK backwards compatability * Add location for SDK backwards compatability * fix examples add location * Update description * Add read to x-ms-mutability snapshotid and backupid * Add simpler Create Account example without AD * pretty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM API Information (Control Plane)
https://portal.azure-devex-tools.com/amekpis/correctness/detail?errorId=25ED1D20-BECF-4D62-AA0A-F7FC90C8C009
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Azure 1st Party Service can try out the Shift Left experience to initiate API design review from ADO code repo. If you are interested, may request engineering support by filling in with the form https://aka.ms/ShiftLeftSupportForm.
Changelog
Add a changelog entry for this PR by answering the following questions:
Contribution checklist (MS Employees Only):
If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist
Otherwise your PR may be subject to ARM review requirements. Complete the following:
Check this box if any of the following apply to the PR so that the label "ARMReview" and "WaitForARMFeedback" will be added by bot to kick off ARM API Review. Missing to check this box in the following scenario may result in delays to the ARM manifest review and deployment.
-[ ] To review changes efficiently, ensure you copy the existing version into the new directory structure for first commit and then push new changes, including version updates, in separate commits. You can use OpenAPIHub to initialize the PR for adding a new version. For more details refer to the wiki.
Ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.
If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Breaking Change Review Checklist
If you have any breaking changes as defined in the Breaking Change Policy, request approval from the Breaking Change Review Board.
Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Additional details on the process and office hours are on the Breaking Change Wiki.
NOTE: To update API(s) in public preview for over 1 year (refer to Retirement of Previews)
Please follow the link to find more details on PR review process.