Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] sdk/resourcemanager/netapp/armnetapp/4.0.0 #20361

Merged
merged 8 commits into from
Mar 24, 2023
Merged

[Release] sdk/resourcemanager/netapp/armnetapp/4.0.0 #20361

merged 8 commits into from
Mar 24, 2023

Conversation

azure-sdk
Copy link
Collaborator

[Release] sdk/resourcemanager/netapp/armnetapp/4.0.0 generation from …
281bbd2 
…spec commit: 1e7b408f3323e7f5424745718fe62c7a043a2337
RickWinter
RickWinter previously requested changes Mar 10, 2023
View reviewed changes
Copy link
Member

@RickWinter RickWinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JeffreyRichter can you review the breaking changes. The removal of types would be nice to deprecate and not remove. Granted thats a hard problem as the swagger won't have the previous type for us to generate&deprecate.

@tadelesh
Copy link
Member

The breaking changes are introduced and approved in this PR.

@tadelesh
Copy link
Member

@JeffreyRichter can you review the breaking changes. The removal of types would be nice to deprecate and not remove. Granted thats a hard problem as the swagger won't have the previous type for us to generate&deprecate.

It is hard to maintain if we could not do the deprecation by tools. Currently, swagger does not provide deprecation feature.

@tadelesh
Copy link
Member

The breaking changes are introduced and approved in this swagger PR. @JeffreyRichter could you please approve this major version release with adding Approved Major Version label?

@tadelesh tadelesh requested a review from RickWinter March 23, 2023 09:48
@tadelesh tadelesh dismissed RickWinter’s stale review March 24, 2023 07:55

Major version has been approved by Jeff.

@Alancere Alancere merged commit d4dafa3 into main Mar 24, 2023
@Alancere Alancere deleted the release-netapp-armnetapp-4.0.0-1678237684 branch March 24, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@lirenhe lirenhe Awaiting requested review from lirenhe lirenhe is a code owner

@JeffreyRichter JeffreyRichter Awaiting requested review from JeffreyRichter

@RickWinter RickWinter Awaiting requested review from RickWinter

Assignees
No one assigned
Labels
Approved Major Version BreakingChange
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@azure-sdk @tadelesh @RickWinter @JeffreyRichter @Alancere