fix member upate operation #25134

zman-ms · 2023-08-03T01:21:30Z

reduce breaking change of member async update in 2023-06-15-preview

openapi-workflow-bot · 2023-08-03T01:21:32Z

Hi, @zman-ms! Thank you for your pull request. To help get your PR merged:

Ensure you reviewed the checklists in the PR description.

Know that PR assignee is the person auto-assigned and responsible for your current PR review and approval.

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

openapi-pipeline-app · 2023-08-03T01:21:33Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

compared swaggers (via Oad v0.10.4)]	new version	base version
fleets.json	2023-03-15-preview(8f2a190)	2023-03-15-preview(main)

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️⚠️LintDiff: 0 Warnings warning [Detail]

compared tags (via openapi-validator v2.1.3)	new version	base version
package-2023-03-preview	package-2023-03-preview(8f2a190)	package-2023-03-preview(dev-aks-fleet-2023-06-15-preview)

The following errors/warnings exist before current PR submission:

Rule	Message
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: fleet/preview/2023-03-15-preview/fleets.json#L273
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: fleet/preview/2023-03-15-preview/fleets.json#L669
`❌` PutResponseSchemaDescription	Description of 200 response code of a PUT operation MUST include term 'update'. Location: fleet/preview/2023-03-15-preview/fleets.json#L1036
⚠️ SchemaDescriptionOrTitle	Schema should have a description or title. Location: fleet/preview/2023-03-15-preview/fleets.json#L1670

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-03T01:21:33Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

 Please click here to preview with your @microsoft account.

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python-track2 warning [Detail]

⚠️Warning [Logs] Generate from f8a861271dc068b89c6963363d55f6cfe4552235. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
warn		specification/containerservice/Fleet.Management/tspconfig.yaml skipped due to azure-sdk-for-python-track2 not found in tspconfig.yaml
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.6.7 -> 9.8.1
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.8.1>
cmderr	[automation_generate.sh] npm notice Run `npm install -g [email protected]` to update!
cmderr	[automation_generate.sh] npm notice

️✔️track2_azure-mgmt-containerservicefleet [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog]   - Model Fleet has a new parameter identity
info	[Changelog]   - Model FleetHubProfile has a new parameter agent_profile
info	[Changelog]   - Model FleetHubProfile has a new parameter api_server_access_profile
info	[Changelog]   - Model FleetPatch has a new parameter identity
info	[Changelog]   - Model ManagedClusterUpdate has a new parameter node_image_selection
info	[Changelog]   - Model MemberUpdateStatus has a new parameter message
info	[Changelog]   - Model UpdateRunStatus has a new parameter node_image_selection
info	[Changelog]
info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog]   - Renamed operation FleetMembersOperations.update to FleetMembersOperations.begin_update
info	[Changelog]   - Renamed operation FleetsOperations.update to FleetsOperations.begin_update

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from f8a861271dc068b89c6963363d55f6cfe4552235. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.2.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json

️✔️azure-resourcemanager-containerservicefleet [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from f8a861271dc068b89c6963363d55f6cfe4552235. SDK Automation 14.0.0

command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
warn		specification/containerservice/Fleet.Management/tspconfig.yaml skipped due to azure-sdk-for-go not found in tspconfig.yaml
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json

️✔️sdk/resourcemanager/containerservicefleet/armcontainerservicefleet [View full logs] [Preview SDK Changes] Breaking Change Detected

info	[Changelog] ### Breaking Changes
info	[Changelog]
info	[Changelog] - Operation `*FleetMembersClient.Update` has been changed to LRO, use `*FleetMembersClient.BeginUpdate` instead.
info	[Changelog] - Operation `*FleetsClient.Update` has been changed to LRO, use `*FleetsClient.BeginUpdate` instead.
info	[Changelog]
info	[Changelog] ### Features Added
info	[Changelog]
info	[Changelog] - New value `UpdateStateSkipped` added to enum type `UpdateState`
info	[Changelog] - New enum type `ManagedServiceIdentityType` with values `ManagedServiceIdentityTypeNone`, `ManagedServiceIdentityTypeSystemAssigned`, `ManagedServiceIdentityTypeSystemAssignedUserAssigned`, `ManagedServiceIdentityTypeUserAssigned`
info	[Changelog] - New enum type `NodeImageSelectionType` with values `NodeImageSelectionTypeConsistent`, `NodeImageSelectionTypeLatest`
info	[Changelog] - New struct `APIServerAccessProfile`
info	[Changelog] - New struct `AgentProfile`
info	[Changelog] - New struct `ManagedServiceIdentity`
info	[Changelog] - New struct `NodeImageSelection`
info	[Changelog] - New struct `NodeImageSelectionStatus`
info	[Changelog] - New struct `NodeImageVersion`
info	[Changelog] - New struct `UserAssignedIdentity`
info	[Changelog] - New field `Identity` in struct `Fleet`
info	[Changelog] - New field `APIServerAccessProfile`, `AgentProfile` in struct `FleetHubProfile`
info	[Changelog] - New field `Identity` in struct `FleetPatch`
info	[Changelog] - New field `NodeImageSelection` in struct `ManagedClusterUpdate`
info	[Changelog] - New field `Message` in struct `MemberUpdateStatus`
info	[Changelog] - New field `NodeImageSelection` in struct `UpdateRunStatus`
info	[Changelog]
info	[Changelog] Total 2 breaking change(s), 29 additive change(s).

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from f8a861271dc068b89c6963363d55f6cfe4552235. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/arm-containerservicefleet [View full logs] [Preview SDK Changes] Breaking Change Detected

azure-arm-containerservicefleet-1.0.0-beta.2.tgz

info	[Changelog] **Features**
info	[Changelog]
info	[Changelog]   - Added operation FleetMembers.beginUpdate
info	[Changelog]   - Added operation FleetMembers.beginUpdateAndWait
info	[Changelog]   - Added operation Fleets.beginUpdate
info	[Changelog]   - Added operation Fleets.beginUpdateAndWait
info	[Changelog]   - Added Interface AgentProfile
info	[Changelog]   - Added Interface APIServerAccessProfile
info	[Changelog]   - Added Interface FleetMembersUpdateHeaders
info	[Changelog]   - Added Interface FleetsUpdateHeaders
info	[Changelog]   - Added Interface ManagedServiceIdentity
info	[Changelog]   - Added Interface NodeImageSelection
info	[Changelog]   - Added Interface NodeImageSelectionStatus
info	[Changelog]   - Added Interface NodeImageVersion
info	[Changelog]   - Added Interface UserAssignedIdentity
info	[Changelog]   - Added Type Alias ManagedServiceIdentityType
info	[Changelog]   - Added Type Alias NodeImageSelectionType
info	[Changelog]   - Interface Fleet has a new optional parameter identity
info	[Changelog]   - Interface FleetHubProfile has a new optional parameter agentProfile
info	[Changelog]   - Interface FleetHubProfile has a new optional parameter apiServerAccessProfile
info	[Changelog]   - Interface FleetMembersUpdateOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface FleetMembersUpdateOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface FleetPatch has a new optional parameter identity
info	[Changelog]   - Interface FleetsUpdateOptionalParams has a new optional parameter resumeFrom
info	[Changelog]   - Interface FleetsUpdateOptionalParams has a new optional parameter updateIntervalInMs
info	[Changelog]   - Interface ManagedClusterUpdate has a new optional parameter nodeImageSelection
info	[Changelog]   - Interface MemberUpdateStatus has a new optional parameter message
info	[Changelog]   - Interface UpdateRunStatus has a new optional parameter nodeImageSelection
info	[Changelog]   - Added Enum KnownManagedServiceIdentityType
info	[Changelog]   - Added Enum KnownNodeImageSelectionType
info	[Changelog]   - Enum KnownUpdateState has a new value Skipped
info	[Changelog]
info	[Changelog] **Breaking Changes**
info	[Changelog]
info	[Changelog]   - Removed operation FleetMembers.update
info	[Changelog]   - Removed operation Fleets.update

️❌ azure-sdk-for-net-track2 failed [Detail]

❌Failed [Logs] Generate from f8a861271dc068b89c6963363d55f6cfe4552235. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
warn		specification/containerservice/Fleet.Management/tspconfig.yaml skipped due to azure-sdk-for-net-track2 not found in tspconfig.yaml
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk. exit code: False
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGet-ChildItem: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:805
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 805 | �[0m … rtifacts += �[36;1mGet-ChildItem $artifactsPath -Filter *.nupkg -exclude *.s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mCannot find path
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m'/mnt/vss/_work/1/s/azure-sdk-for-net/artifacts/packages/Debug/' because
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1mit does not exist.
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1mGeneratePackage: �[0m/mnt/vss/_work/1/s/azure-sdk-for-net/eng/scripts/automation/GenerateAndBuildLib.ps1:712
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1mLine |
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m 712 | �[0m         �[36;1mGeneratePackage -projectFolder $projectFolder -sdkRootPath $s�[0m …
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[36;1m     | �[31;1m         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[31;1m�[36;1m     | �[31;1mFailed to generate sdk artifact
cmderr	[Invoke-GenerateAndBuildV2.ps1] �[0m

❌Azure.ResourceManager.ContainerService [View full logs] [Preview SDK Changes]
```
info	[Changelog]
```

️⚠️ azure-resource-manager-schemas warning [Detail]

⚠️Warning [Logs] Generate from f8a861271dc068b89c6963363d55f6cfe4552235. Schema Automation 14.0.0

command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
warn	File azure-resource-manager-schemas_tmp/initOutput.json not found to read
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
warn	No file changes detected after generation

️✔️containerservice [View full logs]

️❌ azure-powershell failed [Detail]

❌Pipeline Framework Failed [Logs] Generate from f8a861271dc068b89c6963363d55f6cfe4552235. SDK Automation 14.0.0

command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
warn		specification/containerservice/Fleet.Management/tspconfig.yaml skipped due to azure-powershell not found in tspconfig.yaml
command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
SSL error: syscall failure: Broken pipe
Error: SSL error: syscall failure: Broken pipe

️✔️Az.containerservice.DefaultTag [View full logs]

error	Fatal error: SSL error: syscall failure: Broken pipe
error	The following packages are still pending:
error		Az.containerservice.DefaultTag

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-08-03T01:21:34Z

Generated ApiView

Language	Package Name	ApiView Link
TypeSpec	Fleet.Management	https://apiview.dev/Assemblies/Review/45fffea58a324813962a09babacd6708
Swagger	Microsoft.ContainerService	https://apiview.dev/Assemblies/Review/d2d79ba4d1b64f1082c246afc3be18c9
Go	sdk/resourcemanager/containerservicefleet/armcontainerservicefleet	https://apiview.dev/Assemblies/Review/4baf5e1bcdfb44c6abc71af53b31162b
Java	azure-resourcemanager-containerservicefleet	https://apiview.dev/Assemblies/Review/454d8aac417b44d89ff5b425c3e2495f
JavaScript	@azure/arm-containerservicefleet	https://apiview.dev/Assemblies/Review/a07e3504157a47879e3de6bc4d4538aa

* Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview * Updates readme * Updates API version in new specs and examples * [Fleet][Dev] API 0615 changes (#25020) * Adds base for updating Microsoft.ContainerService/fleet from version preview/2023-03-15-preview to version 2023-06-15-preview * Updates readme * Updates API version in new specs and examples * sync with ADO repo * exclude unneeded file changes * revert tsp config * revert helpers.tsp * remove package files * remove package files * add known word containerd * format * remove .npmrc * revert custom word * revert package-lock.json * re-generate json * add example * add example * fix read-only fields * fix read-only fields * re-generate json with latest compiler * add custom word back * re-generate json * restore config * add examples * add examples * add examples * add examples * add examples * add examples * prettier * fix examples * git ignore * review commoents * fix examples * make node image selection optional * fix warnings * fix warnings * fix warnings * fix docs * revert package changes * compile * fix tspconfig (#25031) * [Fleet][readmes] Dev aks fleet 2023 06 15 preview readmes (#25033) * update readmes * fix readme mistake * fix operationid warnings (#25109) * tsp format (#25111) * Fix aks fleet 2023 06 15 preview patchasync from 0615 (#25131) * do the breaking change only from 0615 * fix patch * compile to get examples * remove sample * fix member upate operation (#25134) * revert extension removal (#25189) * generate with type spec v0.47.0 (#25484) --------- Co-authored-by: Stéphane Erbrech <[email protected]>

fix member upate operation

8f2a190

zman-ms requested review from palma21, weinong, alvinli222, matthchr and circy9 as code owners August 3, 2023 01:21

AzureRestAPISpecReview added the resource-manager label Aug 3, 2023

serbrech approved these changes Aug 3, 2023

View reviewed changes

azure-sdk mentioned this pull request Aug 3, 2023

[AutoPR azure-resourcemanager-containerservicefleet] fix member upate operation azure-sdk/azure-sdk-for-java#6330

Closed

serbrech merged commit 20bbd22 into dev-aks-fleet-2023-06-15-preview Aug 3, 2023

serbrech deleted the fix-aks-fleet-2023-06-15-preview-member-update branch August 3, 2023 01:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix member upate operation #25134

fix member upate operation #25134

zman-ms commented Aug 3, 2023

openapi-workflow-bot bot commented Aug 3, 2023

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

fix member upate operation #25134

fix member upate operation #25134

Conversation

zman-ms commented Aug 3, 2023

openapi-workflow-bot bot commented Aug 3, 2023

openapi-pipeline-app bot commented Aug 3, 2023 • edited Loading

Swagger Validation Report

openapi-pipeline-app bot commented Aug 3, 2023 • edited Loading

Swagger Generation Artifacts

Breaking Changes Tracking

openapi-pipeline-app bot commented Aug 3, 2023 • edited Loading

Generated ApiView

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading

openapi-pipeline-app bot commented Aug 3, 2023 •

edited

Loading