Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

automation: python3 package create is a LRO #25435

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

automation: python3 package create is a LRO #25435

wants to merge 4 commits into from

Conversation

wuxu92
Copy link

@wuxu92 wuxu92 commented Aug 22, 2023

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

[1] ARM review queue (for merge queues, see [4])
The PRs are processed by time opened, ascending. Your PR may show up on 2nd or later page.
If you addressed Step 1 from the diagram and your PR is not showing up in the queue, ensure the label ARMChangesRequested
is removed from your PR. This should cause the label WaitForARMFeedback to be added.
[2] https://aka.ms/azsdk/support/specreview-channel
[3] List of SDK breaking changes approvers in pinned Teams announcement
[4] public repo merge queue, private repo merge queue (for ARM review queue, [1])

If you need further help with anything, see Getting help section below.

Purpose of this PR

What's the purpose of this PR? Check all that apply. This is mandatory!

  • New API version. (Such PR should have been generated with OpenAPI Hub, per this wiki doc.)
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix swagger quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

Breaking changes review (Step 1)

  • If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
    you must follow the breaking changes process.
    IMPORTANT This applies even if:
    • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
    • You believe there is no need for you to request breaking change approval, for any reason.
      Such claims must be reviewed, and the process is the same.

ARM API changes review (Step 2)

  • If this PR is in purview of ARM review then automation will add the ARMReview label.
  • If you want to force ARM review, add the label yourself.
  • Proceed according to the diagram at the top of this comment.

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

Getting help

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is not ready for ARM review (label: NotReadyForARMReview). This PR will not be reviewed by ARM until relevant problems are fixed. Consult the rest of this Next Steps to Merge comment for details.
    Once the blocking problems are addressed, add to the PR a comment with contents /azp run. Automation will re-evaluate this PR and if everything looks good, it will add WaitForARMFeedback label which will put this PR on the ARM review queue.
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review
  • ❌ This PR is NotReadyForARMReview because it has the BreakingChangeReviewRequired label.
  • ❌ This PR has at least one breaking change (label: BreakingChangeReviewRequired).
    To unblock this PR, follow the process at aka.ms/brch.
  • ❌ The required check named Swagger BreakingChange has failed. To unblock this PR, follow the process at aka.ms/brch.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023 •
edited
Loading

Swagger Validation Report

️❌BreakingChange: 5 Errors, 0 Warnings failed [Detail]
Compared specs (v0.10.12) new version base version
module.json 2022-08-08(0c780ef) 2022-08-08(main)
python3package.json 2022-08-08(0c780ef) 2022-08-08(main)
module.json 2023-11-01(0c780ef) 2023-11-01(main)
powershell72Module.json 2023-11-01(0c780ef) 2023-11-01(main)
python3package.json 2023-11-01(0c780ef) 2023-11-01(main)
Rule Message
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Automation/stable/2022-08-08/module.json#L251:7
Old: Microsoft.Automation/stable/2022-08-08/module.json#L251:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Automation/stable/2022-08-08/python3package.json#L140:7
Old: Microsoft.Automation/stable/2022-08-08/python3package.json#L140:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Automation/stable/2023-11-01/module.json#L251:7
Old: Microsoft.Automation/stable/2023-11-01/module.json#L251:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Automation/stable/2023-11-01/powershell72Module.json#L132:7
Old: Microsoft.Automation/stable/2023-11-01/powershell72Module.json#L132:7
❌ 1044 - XmsLongRunningOperationChanged The new version has a different 'x-ms-longrunning-operation' value than the previous one.
New: Microsoft.Automation/stable/2023-11-01/python3package.json#L140:7
Old: Microsoft.Automation/stable/2023-11-01/python3package.json#L140:7
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand] 
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand] 
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-2022-08-08 package-2022-08-08(0c780ef) package-2022-08-08(main)
package-2023-11-01 package-2023-11-01(0c780ef) package-2023-11-01(main)

The following errors/warnings exist before current PR submission:

Only 30 items are listed, please refer to log for more details.

Rule Message
❌ ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L39
❌ ResourceNameRestriction The resource name parameter 'moduleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L39
❌ ResourceNameRestriction The resource name parameter 'activityName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L39
❌ ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L98
❌ ResourceNameRestriction The resource name parameter 'moduleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L98
❌ ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L153
❌ ResourceNameRestriction The resource name parameter 'moduleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L153
❌ DeleteResponseCodes Synchronous delete operations must have responses with 200, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L154
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L239
❌ PutRequestResponseSchemeArm A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Module_CreateOrUpdate' Request Model: 'parameters[3].schema' Response Model: 'responses[200].schema'
Location: Microsoft.Automation/stable/2022-08-08/module.json#L251
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L298
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L304
❌ UnSupportedPatchProperties Mark the top-level property 'name', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L348
❌ UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L348
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:algorithm.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L352
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:value.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L352
❌ ProvisioningStateMustBeReadOnly provisioningState property must be set to readOnly.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L367
❌ ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L380
❌ ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L428
❌ ResourceNameRestriction The resource name parameter 'moduleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L428
❌ ResourceNameRestriction The resource name parameter 'typeName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L428
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L474
❌ ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L490
❌ ResourceNameRestriction The resource name parameter 'typeName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L490
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L529
❌ ResourceNameRestriction The resource name parameter 'automationAccountName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L545
❌ ResourceNameRestriction The resource name parameter 'moduleName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L545
❌ ResourceNameRestriction The resource name parameter 'typeName' should be defined with a 'pattern' restriction.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L545
❌ GetCollectionOnlyHasValueAndNextLink Get endpoints for collections of resources must only have the value and nextLink properties in their model.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L591
❌ MissingTypeObject The schema 'ModuleCreateOrUpdateProperties' is considered an object but without a 'type:object', please add the missing 'type:object'.
Location: Microsoft.Automation/stable/2022-08-08/module.json#L852
️⚠️Avocado: 1 Warnings warning [Detail]
Rule Message
⚠️ MULTIPLE_API_VERSION The default tag contains multiple API versions swaggers.
readme: specification/automation/resource-manager/readme.md
tag: specification/automation/resource-manager/readme.md#tag-package-2023-11-01
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand] 
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand] 
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand] 
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand] 
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand] 
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand] 
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023 •
edited
Loading

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand] 
 Please click here to preview with your @microsoft account.
️🔄 azure-sdk-for-net-track2 inProgress [Detail]
️🔄 azure-sdk-for-python inProgress [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 5ade8e24b1c98b29edc30ece4334a4c595bfd318. SDK Automation 14.0.0 
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/automation/armautomation [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 5ade8e24b1c98b29edc30ece4334a4c595bfd318. SDK Automation 14.0.0 
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-automation [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • ❌Code Generator Failed in generating from 5ade8e24b1c98b29edc30ece4334a4c595bfd318. Schema Automation 14.0.0 
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
cmderr	[initScript.sh] npm notice
cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
cmderr	[initScript.sh] npm notice To update run: npm install -g [email protected]
cmderr	[initScript.sh] npm notice
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500
cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
cmderr	[generateScript.sh]            ^
cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:500:12)
cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:504:19)
cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:739:36)
cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:955:32)
cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1043:43)
cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/[email protected][email protected]/node_modules/ts-node/src/index.ts:1046:12)
cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️🔄 azure-powershell inProgress [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Aug 22, 2023 •
edited
Loading

Generated ApiView

Language Package Name ApiView Link
Go sdk/resourcemanager/automation/armautomation https://apiview.dev/Assemblies/Review/0c7b4a9e6b4b4de9b750ccf18148dd7e?revisionId=3086476957314a6c93df82461b0a62be
JavaScript @azure/arm-automation https://apiview.dev/Assemblies/Review/96f003ba012746828eb56c3795863cc4?revisionId=e1eb8d8435714d29b8d5200ce833ef2c
Swagger Microsoft.Automation https://apiview.dev/Assemblies/Review/00db6caae22e42bf881f05eae1a48849?revisionId=1c9cc0a58c4b4ccea3eb5ba4553e29db

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review ARMReview BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager labels Aug 22, 2023
@openapi-workflow-bot
Copy link

Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
This will notify the reviewer to have another look.
If the feedback provided needs further discussion, please use this Teams channel to post your questions - aka.ms/azsdk/support/specreview-channel.
Please include [ARM Query] in the title of your question to indicate that it is ARM-related.

@azure-sdk azure-sdk mentioned this pull request Aug 22, 2023
Closed
This was referenced Aug 22, 2023
Closed
Closed
@azure-sdk azure-sdk mentioned this pull request Aug 22, 2023
Closed
@wuxu92 wuxu92 mentioned this pull request Aug 22, 2023
Merged
@microsoft-github-policy-service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

6 similar comments
@microsoft-github-policy-service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label May 6, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels May 27, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jun 17, 2024
@tombuildsstuff
Copy link
Contributor

@rkmanda any chance you'd be able to take a look at/merge this PR? As it stands we're having to re-open this every once in a while, when this is a correctness issue

@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Jun 17, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hi, @wuxu92. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove no-recent-activity label.

@microsoft-github-policy-service microsoft-github-policy-service bot added the no-recent-activity There has been no recent activity on this issue. label Jul 8, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Jul 8, 2024
@azure-sdk azure-sdk mentioned this pull request Jul 8, 2024
Closed
@AzureRestAPISpecReview AzureRestAPISpecReview added NotReadyForARMReview and removed ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jul 8, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 8, 2024
This was referenced Jul 8, 2024
Closed
Closed
@TimLovellSmith TimLovellSmith added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jul 8, 2024
@TimLovellSmith
Copy link
Member

TimLovellSmith commented Jul 8, 2024 •
edited
Loading

@wuxu2 if you're still working on this could you please fix or add suppressions of the lintdiff errors. (See suppressions in other readme.md files for example suppressions)

@TimLovellSmith TimLovellSmith added the ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review label Jul 8, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 8, 2024
@AzureRestAPISpecReview AzureRestAPISpecReview added ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test SuppressionReviewRequired and removed ARMChangesRequested <valid label in PR review process>add this label when require changes after ARM review labels Jul 9, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2024
@madhura-np madhura-np removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 9, 2024
@madhura-np
Copy link
Member

Please get breaking change review -
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rkmanda rkmanda

Labels
ARMReview BreakingChange-Go-Sdk BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required customer-reported Issues that are reported by GitHub users external to the Azure organization. NotReadyForARMReview ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@wuxu92 @tombuildsstuff @stephybun @TimLovellSmith @madhura-np @rkmanda @azure-sdk @AzureRestAPISpecReview @msyyc