Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automation:add new workaround for automation python3package lro #2967

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

wuxu92
Copy link
Collaborator

@wuxu92 wuxu92 commented Aug 22, 2023

add a workaround for Azure/azure-rest-api-specs#25435

Comment on lines 9 to 22
var _ workaround = workaroundAutomation25434{}

type workaroundAutomation25434 struct {
}

func (workaroundAutomation25434) IsApplicable(apiDefinition *models.AzureApiDefinition) bool {
return apiDefinition.ServiceName == "Automation" && apiDefinition.ApiVersion == "2022-08-08"
}

func (workaroundAutomation25434) Name() string {
return "Automation / 25434"
}

func (workaroundAutomation25434) Process(apiDefinition models.AzureApiDefinition) (*models.AzureApiDefinition, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25434?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, typo fixed.

@@ -11,6 +11,7 @@ var workarounds = []workaround{
workaroundAuthorization25080{},
workaroundDigitalTwins25120{},
workaroundAutomation25108{},
workaroundAutomation25434{},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

25434?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

)

var _ workaround = workaroundAutomation25434{}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the issue here as well as a brief summary on the issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

Copy link
Member

@stephybun stephybun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wuxu92 LGTM 🐞

@stephybun stephybun merged commit 34ba542 into hashicorp:main Aug 23, 2023
@wuxu92 wuxu92 deleted the workaround/py3lro branch August 24, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants