Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'privateDnsZoneId' to ServiceResource.properties.vnetAddons #28099

Merged
merged 6 commits into from
Mar 12, 2024

add private dns id

12d3adf
Select commit
Loading
Failed to load commit list.
Merged

Add 'privateDnsZoneId' to ServiceResource.properties.vnetAddons #28099

add private dns id
12d3adf
Select commit
Loading
Failed to load commit list.
openapi-pipeline-app / Swagger LintDiff succeeded Mar 12, 2024 in 4m 22s

Swagger LintDiff succeeded

LintDiff
View Azure DevOps build log for more details.

Details

Compared specs (v2.2.0) new version base version
package-preview-2024-05 package-preview-2024-05(12d3adf) package-preview-2024-05(dev-appplatform-Microsoft.AppPlatform-2024-05-01-preview)

The following errors/warnings exist before current PR submission:
Only 50 items are listed, please refer to log for more details.

Rule Message
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L63
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L105
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L134
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L158
❌ UnSupportedPatchProperties Mark the top-level property 'location', specified in the patch operation body, as readOnly or immutable. You could also choose to remove it from the request payload of the Patch operation. This property is not patchable.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L197
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:type.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L202
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:frequency.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L202
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:name.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L202
❌ PatchBodyParametersSchema Properties of a PATCH request body must not have default value, property:tier.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L202
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L214
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L410
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L431
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L434
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L438
❌ PostResponseCodes Long-running POST operations must have responses with 202 and default return codes. They must also have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified. They also must not have other response codes.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L458
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L479
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L482
❌ NoErrorCodeResponses Invalid status code specified. Please refer to the documentation for the allowed set.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L486
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L641
❌ PostResponseCodes 200 return code does not have a schema specified. LRO POST must have a 200 return code if only if the final response is intended to have a schema, if not the 200 return code must not be specified.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L701
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1007
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1048
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1049
❌ EvenSegmentedPathForPutOperation API path with PUT operation defined MUST have even number of segments (i.e. end in {resourceType}/{resourceName} segments).
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1218
❌ XmsPageableForListCalls x-ms-pageable extension must be specified for LIST APIs.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1219
❌ ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1262
❌ PutResponseCodes Synchronous and long-running PUT operations must have responses with 200, 201 and default return codes. They also must not have other response codes.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1262
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1298
❌ PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:uri.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1345
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1357
❌ PathForResourceAction Path for 'post' method on a resource type MUST follow valid resource naming.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1381
❌ PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1382
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1418
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1545
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1572
❌ PostResponseCodes 202 response for a LRO POST operation must not have a response schema specified.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1639
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1678
❌ ResourceNameRestriction The resource name parameter 'serviceRegistryName' should be defined with a 'pattern' restriction.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1768
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1862
❌ LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L1889
❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'BuildService' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L2627
❌ ResourceNameRestriction The resource name parameter 'buildServiceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L2666
❌ OperationIdNounVerb Per the Noun_Verb convention for Operation Ids, the noun 'BuildService' should not appear after the underscore. Note: If you have already shipped an SDK on top of this spec, fixing this warning may introduce a breaking change.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L2672
❌ ResourceNameRestriction The resource name parameter 'buildServiceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L2773
❌ ResourceNameRestriction The resource name parameter 'buildServiceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L2821
❌ ResourceNameRestriction The resource name parameter 'buildName' should be defined with a 'pattern' restriction.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L2821
❌ ResourceNameRestriction The resource name parameter 'buildServiceName' should be defined with a 'pattern' restriction.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L3030
❌ ResourceNameRestriction The resource name parameter 'builderName' should be defined with a 'pattern' restriction.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L3030
❌ ResourceNameRestriction The resource name parameter 'buildpackBindingName' should be defined with a 'pattern' restriction.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L3030
❌ DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.AppPlatform/preview/2024-05-01-preview/appplatform.json#L3145
View more details on openapi-pipeline-app