-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add extension metadata V2 API and example #30656
Conversation
Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2024-07-31-preview to preview/2024-09-10-preview.
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
Update the Purpose of this PR as this is a version update from what i see in file |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
"type": "array", | ||
"readOnly": true, | ||
"items": { | ||
"type": "string" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...mpute/resource-manager/Microsoft.HybridCompute/preview/2024-09-10-preview/HybridCompute.json
Show resolved
Hide resolved
...mpute/resource-manager/Microsoft.HybridCompute/preview/2024-09-10-preview/HybridCompute.json
Show resolved
Hide resolved
...mpute/resource-manager/Microsoft.HybridCompute/preview/2024-09-10-preview/HybridCompute.json
Outdated
Show resolved
Hide resolved
...mpute/resource-manager/Microsoft.HybridCompute/preview/2024-09-10-preview/HybridCompute.json
Show resolved
Hide resolved
...mpute/resource-manager/Microsoft.HybridCompute/preview/2024-09-10-preview/HybridCompute.json
Show resolved
Hide resolved
should the newly added models v2 match with this sub level operations? Refers to: specification/hybridcompute/resource-manager/Microsoft.HybridCompute/preview/2024-09-10-preview/HybridCompute.json:1514 in 9f88be5. [](commit_id = 9f88be5, deletion_comment = False) |
"$ref": "../../../../../common-types/resource-management/v3/types.json#/parameters/ApiVersionParameter" | ||
}, | ||
{ | ||
"name": "location", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 5e44134.
Hi, I meant to say that, if the response is changing when the request starts with '/subscription/{subscriptionId}', this means it is specific to that scope , even if the 'provider/location/publisher/extensionType/version' is same. |
@ramoka178 - What do you suggest for the API Path at the Provider level? Note that we would like the signature to be somewhat consistent with IaaS VMs (Compute RP) |
Could you check the suggestion at #30656 (comment) . I am not sure what is the IaaS VMs APIs are though. |
* use v3 common-types * prettier * attempt v5 common types * dummy change to trigger checks * Revert "dummy change to trigger checks" This reverts commit 9925d24. * Revert "attempt v5 common types" This reverts commit 4ed6fa4. * update to v5 * update subscriptionid to guid format in examples * fix examples in machines * Revert "fix examples in machines" This reverts commit cf84a91. * fix model validation * fix model validation * prettier * prettier * prettier * Revert "prettier" This reverts commit ea820f1. * Revert "prettier" This reverts commit 68b5bb6. * Revert "prettier" This reverts commit e5065de. * Revert "fix model validation" This reverts commit 4b0723f. * Revert "fix model validation" This reverts commit 9ad91b4. * Reapply "fix examples in machines" This reverts commit 8f00a27. * Revert "fix examples in machines" This reverts commit cf84a91. * Revert "update subscriptionid to guid format in examples" This reverts commit 8f1af4d. * Revert "update to v5" This reverts commit e0083cf. * Reapply "attempt v5 common types" This reverts commit 3df6b50. * Reapply "dummy change to trigger checks" This reverts commit 0956f17. * Revert "dummy change to trigger checks" This reverts commit 9925d24. * use v3 common type * Update sdk-suppressions.yaml --------- Co-authored-by: Jiaqi Li <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
@ramoka178 - If you are referring to "/providers/Microsoft.HybridCompute/locations/{location}/publishers/{publisher}/aggregatedExtensionTypes/{extensionType}/versions", then the phrase 'aggregated' does not fit in the context as we serve a single Type or Collection, for a given Publisher. This is not consistent with the way Customers work with Extension Types in other APIs We scheduled a API Modelling review in Nov to further discuss this topic. Thanks. |
…0-preview' into add-models
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Past reviewer rejected the API paths added in this PR given they have the same scope as existing API paths returning different response. But as explained here and previous discussion, our use case requires this design. Please review again if possible. We have scheduled API modeling office hour if in Nov if still needed by then. |
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
Hi, @jiaqi-beep. Your PR has no update for 14 days and it is marked as stale PR. If no further update for over 14 days, the bot will close the PR. If you want to refresh the PR, please remove |
Hi, @jiaqi-beep. The PR will be closed since the PR has no update for 28 days. If you still need the PR review to proceed, please reopen it and @ mention PR assignee. |
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.