-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use v3 common-types #31063
use v3 common-types #31063
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Generated ApiView
|
@jiaqi-beep Could you please comment on this revert to v3 , as v5 is highly suggested. |
…0-preview' into v3-common-types
…-api-specs into v3-common-types
This change is a result of breaking change cross version check failure #30546, and discussion with @mikeharder suggests we should unify common type versions. We are converting to v3 because most of the existing common type usage is in v3, only a handful in v5. Also attempting to convert common types to v5 triggers more cross version check failures. Could you explain why v5 is highly suggested? |
This reverts commit 68b5bb6.
This reverts commit e5065de.
This reverts commit 4b0723f.
This reverts commit 9ad91b4.
This reverts commit 8f00a27.
This reverts commit cf84a91.
This reverts commit 8f1af4d.
This reverts commit e0083cf.
This reverts commit 3df6b50.
This reverts commit 0956f17.
This reverts commit 9925d24.
8347c9a
into
release-hybridcompute-Microsoft.HybridCompute-2024-09-10-preview
…0546) * Copy files from preview/2024-07-31-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-09-10-preview Updated the API version from preview/2024-07-31-preview to preview/2024-09-10-preview. * Added tag for 2024-09-10-preview in readme file * add extension setup API and example (#30592) * add extension setup API and example --------- Co-authored-by: Ved Kale <[email protected]> * use v3 common-types (#31063) * use v3 common-types * prettier * attempt v5 common types This reverts commit 9925d24. * Revert "attempt v5 common types" This reverts commit 4ed6fa4. * update to v5 * update subscriptionid to guid format in examples * fix examples in machines * Revert "fix examples in machines" This reverts commit cf84a91. * fix model validation * fix model validation * prettier * prettier * prettier * Revert "prettier" This reverts commit ea820f1. * Revert "prettier" This reverts commit 68b5bb6. * Revert "prettier" This reverts commit e5065de. * Revert "fix model validation" This reverts commit 4b0723f. * Revert "fix model validation" This reverts commit 9ad91b4. * Reapply "fix examples in machines" This reverts commit 8f00a27. * Revert "fix examples in machines" This reverts commit cf84a91. * Revert "update subscriptionid to guid format in examples" This reverts commit 8f1af4d. * Revert "update to v5" This reverts commit e0083cf. * Reapply "attempt v5 common types" This reverts commit 3df6b50. * Reapply "dummy change to trigger checks" This reverts commit 0956f17. * Revert "dummy change to trigger checks" This reverts commit 9925d24. * use v3 common type * Update sdk-suppressions.yaml --------- Co-authored-by: Jiaqi Li <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Microsoft.HybridCompute-2024-09-10-preview update API and swagger with better naming (#31346) Co-authored-by: Ved Kale <[email protected]> --------- Co-authored-by: Ved Kale <[email protected]> Co-authored-by: jiaqi-beep <[email protected]> Co-authored-by: Jiaqi Li <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
…ure#30546) * Copy files from preview/2024-07-31-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-09-10-preview Updated the API version from preview/2024-07-31-preview to preview/2024-09-10-preview. * Added tag for 2024-09-10-preview in readme file * add extension setup API and example (Azure#30592) * add extension setup API and example --------- Co-authored-by: Ved Kale <[email protected]> * use v3 common-types (Azure#31063) * use v3 common-types * prettier * attempt v5 common types This reverts commit 9925d24. * Revert "attempt v5 common types" This reverts commit 4ed6fa4. * update to v5 * update subscriptionid to guid format in examples * fix examples in machines * Revert "fix examples in machines" This reverts commit cf84a91. * fix model validation * fix model validation * prettier * prettier * prettier * Revert "prettier" This reverts commit ea820f1. * Revert "prettier" This reverts commit 68b5bb6. * Revert "prettier" This reverts commit e5065de. * Revert "fix model validation" This reverts commit 4b0723f. * Revert "fix model validation" This reverts commit 9ad91b4. * Reapply "fix examples in machines" This reverts commit 8f00a27. * Revert "fix examples in machines" This reverts commit cf84a91. * Revert "update subscriptionid to guid format in examples" This reverts commit 8f1af4d. * Revert "update to v5" This reverts commit e0083cf. * Reapply "attempt v5 common types" This reverts commit 3df6b50. * Reapply "dummy change to trigger checks" This reverts commit 0956f17. * Revert "dummy change to trigger checks" This reverts commit 9925d24. * use v3 common type * Update sdk-suppressions.yaml --------- Co-authored-by: Jiaqi Li <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Microsoft.HybridCompute-2024-09-10-preview update API and swagger with better naming (Azure#31346) Co-authored-by: Ved Kale <[email protected]> --------- Co-authored-by: Ved Kale <[email protected]> Co-authored-by: jiaqi-beep <[email protected]> Co-authored-by: Jiaqi Li <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
…ure#30546) * Copy files from preview/2024-07-31-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-09-10-preview Updated the API version from preview/2024-07-31-preview to preview/2024-09-10-preview. * Added tag for 2024-09-10-preview in readme file * add extension setup API and example (Azure#30592) * add extension setup API and example --------- Co-authored-by: Ved Kale <[email protected]> * use v3 common-types (Azure#31063) * use v3 common-types * prettier * attempt v5 common types This reverts commit 9925d24. * Revert "attempt v5 common types" This reverts commit 4ed6fa4. * update to v5 * update subscriptionid to guid format in examples * fix examples in machines * Revert "fix examples in machines" This reverts commit cf84a91. * fix model validation * fix model validation * prettier * prettier * prettier * Revert "prettier" This reverts commit ea820f1. * Revert "prettier" This reverts commit 68b5bb6. * Revert "prettier" This reverts commit e5065de. * Revert "fix model validation" This reverts commit 4b0723f. * Revert "fix model validation" This reverts commit 9ad91b4. * Reapply "fix examples in machines" This reverts commit 8f00a27. * Revert "fix examples in machines" This reverts commit cf84a91. * Revert "update subscriptionid to guid format in examples" This reverts commit 8f1af4d. * Revert "update to v5" This reverts commit e0083cf. * Reapply "attempt v5 common types" This reverts commit 3df6b50. * Reapply "dummy change to trigger checks" This reverts commit 0956f17. * Revert "dummy change to trigger checks" This reverts commit 9925d24. * use v3 common type * Update sdk-suppressions.yaml --------- Co-authored-by: Jiaqi Li <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Microsoft.HybridCompute-2024-09-10-preview update API and swagger with better naming (Azure#31346) Co-authored-by: Ved Kale <[email protected]> --------- Co-authored-by: Ved Kale <[email protected]> Co-authored-by: jiaqi-beep <[email protected]> Co-authored-by: Jiaqi Li <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
…0546) * Copy files from preview/2024-07-31-preview Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to preview/2024-09-10-preview Updated the API version from preview/2024-07-31-preview to preview/2024-09-10-preview. * Added tag for 2024-09-10-preview in readme file * add extension setup API and example (#30592) * add extension setup API and example --------- Co-authored-by: Ved Kale <[email protected]> * use v3 common-types (#31063) * use v3 common-types * prettier * attempt v5 common types This reverts commit 9925d24. * Revert "attempt v5 common types" This reverts commit 4ed6fa4. * update to v5 * update subscriptionid to guid format in examples * fix examples in machines * Revert "fix examples in machines" This reverts commit cf84a91. * fix model validation * fix model validation * prettier * prettier * prettier * Revert "prettier" This reverts commit ea820f1. * Revert "prettier" This reverts commit 68b5bb6. * Revert "prettier" This reverts commit e5065de. * Revert "fix model validation" This reverts commit 4b0723f. * Revert "fix model validation" This reverts commit 9ad91b4. * Reapply "fix examples in machines" This reverts commit 8f00a27. * Revert "fix examples in machines" This reverts commit cf84a91. * Revert "update subscriptionid to guid format in examples" This reverts commit 8f1af4d. * Revert "update to v5" This reverts commit e0083cf. * Reapply "attempt v5 common types" This reverts commit 3df6b50. * Reapply "dummy change to trigger checks" This reverts commit 0956f17. * Revert "dummy change to trigger checks" This reverts commit 9925d24. * use v3 common type * Update sdk-suppressions.yaml --------- Co-authored-by: Jiaqi Li <[email protected]> Co-authored-by: Yuchao Yan <[email protected]> * Microsoft.HybridCompute-2024-09-10-preview update API and swagger with better naming (#31346) Co-authored-by: Ved Kale <[email protected]> --------- Co-authored-by: Ved Kale <[email protected]> Co-authored-by: jiaqi-beep <[email protected]> Co-authored-by: Jiaqi Li <[email protected]> Co-authored-by: Yuchao Yan <[email protected]>
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting help
section at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiView
comment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PR
andDue diligence checklist
.write access
per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Merge
comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queued
state, please add a comment with contents/azp run
.This should result in a new comment denoting a
PR validation pipeline
has started and the checks should be updated after few minutes.