Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add details about the vcpkg triplet and unique key chosen for caching as a comment within the vcpkg.yml #1534

Closed
ahsonkhan opened this issue Dec 1, 2020 · 1 comment
Closed

Add details about the vcpkg triplet and unique key chosen for caching as a comment within the vcpkg.yml #1534

ahsonkhan opened this issue Dec 1, 2020 · 1 comment
Labels
EngSys This issue is impacting the engineering system. good first issue This issue tracks work that may be a good starting point for a first-time contributor help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Milestone
[2021] June

Comments

@ahsonkhan
Copy link
Contributor

See #1381 (comment)

Add the details from that conversation above this step:

azure-sdk-for-c/eng/pipelines/templates/steps/vcpkg.yml

Lines 27 to 37 in 399b1ae

- task: Cache@2
inputs:
key: >-
$(Agent.JobName)
| "$(VcpkgCommit)"
| $(Agent.Os)
| $(${{ parameters.DependenciesVariableName }})
| $(VCPKG_DEFAULT_TRIPLET)
path: $(VCPKG_INSTALLATION_ROOT)
cacheHitVar: VcpkgRestoredFromCache
displayName: Vcpkg Cache

@ahsonkhan ahsonkhan added EngSys This issue is impacting the engineering system. help wanted This issue is tracking work for which community contributions would be welcomed and appreciated labels Dec 1, 2020
@ahsonkhan ahsonkhan added this to the Backlog milestone Dec 1, 2020
@ahsonkhan ahsonkhan mentioned this issue Dec 1, 2020
Merged
@ahsonkhan ahsonkhan added the good first issue This issue tracks work that may be a good starting point for a first-time contributor label Dec 2, 2020
@sappyh sappyh mentioned this issue Feb 27, 2021
Merged
ghost pushed a commit that referenced this issue Apr 27, 2021
@sappyh
Adding comment for vcpkg triplet in the unique key for caching (#1623)
2051584 
Commenting the details about the vcpkg triplet to resolve issue #1534
@ahsonkhan
Copy link
Contributor Author

Fixed in #1623

@RickWinter RickWinter modified the milestones: Backlog, [2021] June Sep 27, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
EngSys This issue is impacting the engineering system. good first issue This issue tracks work that may be a good starting point for a first-time contributor help wanted This issue is tracking work for which community contributions would be welcomed and appreciated
Projects
None yet
Milestone
[2021] June
Development

No branches or pull requests
2 participants
@RickWinter @ahsonkhan