Adding comment for vcpkg triplet in the unique key for caching

[sappyh]

Commenting the details about the vcpkg triplet to resolve issue #1534

[ghost]

Thank you for your contribution sappyh! We will review the pull request and get back to you soon.

[RickWinter]

@danieljurek Are you working on switching to vcpkg's cache?

[danieljurek]

@sappyh -- Thanks for your contribution! I've added a couple points of feedback to address before we can sign off and merge your PR. Let me know if you have any questions.

[danieljurek]

Please remove the #TODO comment here. I've filed this issue to track investigating this: Azure/azure-sdk-for-cpp#1765

[ahsonkhan]

Suggested change

# TODO: Use RFC: Binarycaching in vcpkg can be used for more flexible and less error-prone approach

[danieljurek]

This is true. However, a significant example case we're avoiding is using an x86 build of curl on an x64 build of the SDK libraries. The triplet here lets us capture the target platform architecture, OS (though this is better captured in $(Agent.Os)), and linking configuration (static/dynamic) in one variable.

Please update the comment with the example. This will make the value of VCPKG_DEFAULT_TRIPLET immediately more clear to developers who end up here later.

[ahsonkhan]

Please update the comment with the example.

@danieljurek can you please give a concrete GitHub suggestion with the example you prefer to be added here.

[ahsonkhan]

Looks good to me, but since we are in a code freeze while releasing our next version, please hold off on merging for the next day or so.

Thanks for the fix @sappyh

[ahsonkhan]

Looks like some link verification is failing. @sappyh can you pull in Azure:master into your branch since it might be out-dated.

https://dev.azure.com/azure-sdk/public/_build/results?buildId=773945&view=logs&j=a129effc-2dd1-54d1-fb5a-ad7bdc0e851d&t=ccad100f-2904-5913-2083-c525ad929a03

##[warning][404] broken link ***/blob/481cd97206ec6884fcb88ffec3db44e6fdc98337/sdk/samples/iot/docs/how_to_iot_hub_esp32.md
Found 3 links on page file:///D:/a/_work/1/s/sdk/docs/platform/README.md
Found 1 links on page file:///D:/a/_work/1/s/sdk/samples/core/README.md
Found 27 links on page file:///D:/a/_work/1/s/sdk/samples/iot/docs/how_to_iot_hub_esp32.md
##[warning][404] broken link ***/blob/481cd97206ec6884fcb88ffec3db44e6fdc98337/sdk/samples/iot/aziot_esp32

@sima-zhu - was there a recent fix in engsys around link verification? It looks like whenever folks submit a PR branched off of an older commit, we see this link verification error.

[RickWinter]

@ahsonkhan Are we waiting on the contributor for this?

[ahsonkhan]

Nope, just waiting for @danieljurek to approve or dismiss the changes requested and we can merge it :)

[ghost]

Hello @ahsonkhan!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ahsonkhan]

@msftbot wait until @danieljurek approves

[ghost]

Hello @ahsonkhan!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

• I'll only merge this pull request if it's approved by @danieljurek

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".