Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable checkstyle suppressions for Track 2 libraries #18279

Closed
4 tasks done
samvaity opened this issue Dec 18, 2020 · 5 comments
Closed
4 tasks done

Disable checkstyle suppressions for Track 2 libraries #18279

samvaity opened this issue Dec 18, 2020 · 5 comments
Assignees
@anuchandy @srnagar
Labels
Checkstyle Label for tracking tasks related to checkstyle rules Client This issue points to a problem in the data-plane of the library. Cognitive - Anomaly Detector Schema Registry
Milestone
Backlog

Comments

@samvaity
Copy link
Member

samvaity commented Dec 18, 2020 •
edited
Loading

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 18, 2020
@samvaity samvaity added Client This issue points to a problem in the data-plane of the library. Event Grid labels Dec 18, 2020
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 18, 2020
@samvaity samvaity changed the title Disable checkstyle suppressions for eventgrid Disable checkstyle suppressions for Track 2 libraries Dec 29, 2020
@samvaity samvaity added the Checkstyle Label for tracking tasks related to checkstyle rules label Dec 29, 2020
@samvaity samvaity mentioned this issue Dec 30, 2020
Closed
@YijunXieMS YijunXieMS added this to the [2021] March milestone Feb 10, 2021
@samvaity
Copy link
Member Author

@srnagar could you take look at the anomaly detector code changes for this issue?

@YijunXieMS
Copy link
Contributor

EventGrid enabled checkstyle. This was removed from checkstyle-suppressions.xml

<suppress checks="[a-zA-Z0-9]*" files="[/\\]azure-messaging-eventgrid[/\\]src[/\\]"/>

@azabbasi azabbasi mentioned this issue Jul 7, 2021
Merged
@azabbasi
Copy link
Contributor

azabbasi commented Jul 8, 2021

There are a few required changes by the checkstyle plugin that we cannot address. They are recommendations on the public API method signatures that have already gone GA. We will still need to suppress the checkstyle for the sync and async clients as well as the generated layer as we have no control over the code style there.
Does that satisfy the requirements of this issue?

@samvaity
Copy link
Member Author

samvaity commented Jul 8, 2021

There are a few required changes by the checkstyle plugin that we cannot address. They are recommendations on the public API method signatures that have already gone GA. We will still need to suppress the checkstyle for the sync and async clients as well as the generated layer as we have no control over the code style there.
Does that satisfy the requirements of this issue?

Yes, those should be fine. We mainly wanted to address the removal of the wildcard suppression suppress checks="[a-zA-Z0-9]*" for digital twins. Thanks !

@joshfree joshfree assigned anuchandy and unassigned YijunXieMS Sep 8, 2021
@joshfree joshfree modified the milestones: [2021] March, Backlog Sep 8, 2021
@samvaity
Copy link
Member Author

Generic checkstyle suppression disabled for all mentioned libs.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-java that referenced this issue Apr 12, 2022
@harics24
CodeGen from PR 18279 in Azure/azure-rest-api-specs
e3b7fc8 
Skumar/rch metadata api (Azure#18279)

* Defining the APIs for the new NSP resource

* adding metadata API details

* updating ResourceHealth.json

* fixed resourcehealth.json

* fixing linter issues rch metadata

* prettier fixes

* additional linting fixes

* additional linting fixes

* suggesting lintf fixes

* model fixes

* model fixes 2

* model fixes 2

Co-authored-by: Hari Prasad Perabattula <[email protected]>
Co-authored-by: Hari Prasad Perabattula <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anuchandy anuchandy

@srnagar srnagar

Labels
Checkstyle Label for tracking tasks related to checkstyle rules Client This issue points to a problem in the data-plane of the library. Cognitive - Anomaly Detector Schema Registry
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@joshfree @anuchandy @samvaity @azabbasi @YijunXieMS @srnagar