Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADT: Update checkstyle-suppressions.xml to remove digital twins * suppression rule. #22824

Merged
merged 12 commits into from
Jul 9, 2021

Conversation

azabbasi
Copy link
Contributor

@azabbasi azabbasi commented Jul 7, 2021

#18279

We ended up suppressing the checkstyle for the following areas:

  • implementation package (auto generated code, we have no control over the format)
  • Sync and Async client code due to required changes that are breaking behavior

image

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

Copy link
Member

@JonathanGiles JonathanGiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to see!

@azabbasi
Copy link
Contributor Author

azabbasi commented Jul 7, 2021

/azp run java - digitaltwins - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

Copy link
Member

@srnagar srnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@azabbasi
Copy link
Contributor Author

azabbasi commented Jul 7, 2021

There are quite a few check style errors that I am going to resolve shortly.

@azabbasi azabbasi changed the title ADT: Update checkstyle-suppressions.xml to remove digital twins check suppression. ADT: Update checkstyle-suppressions.xml to remove digital twins * suppression rule. Jul 8, 2021
@azabbasi
Copy link
Contributor Author

azabbasi commented Jul 9, 2021

/azp run java - digitaltwins - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi
Copy link
Contributor Author

azabbasi commented Jul 9, 2021

/azp run java - digitaltwins - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi azabbasi enabled auto-merge (squash) July 9, 2021 21:13
@azabbasi azabbasi merged commit 3ae6af8 into main Jul 9, 2021
@azabbasi azabbasi deleted the feature/adt/azabbasi/removesuppression branch July 9, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants