[TA] Based on latest v3.1-preview.5 and added disableServiceLogs and AnalyzeSentimen action support #21262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mssfang
requested review from
deyaaeldeen,
kristapratico,
maririos,
alzimmermsft and
anuchandy
mssfang
added
the
Client
...ure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeActionsAsyncClient.java
Show resolved
Hide resolved
.../azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/Utility.java
Outdated
Show resolved
Hide resolved
.../azure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/implementation/Utility.java
Outdated
Show resolved
Hide resolved
maririos
reviewed
May 10, 2021
...ure-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeActionsAsyncClient.java
Show resolved
Hide resolved
maririos
reviewed
May 10, 2021
...lytics/src/main/java/com/azure/ai/textanalytics/models/AnalyzeHealthcareEntitiesOptions.java
Show resolved
Hide resolved
...e-ai-textanalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsActions.java
Show resolved
Hide resolved
|
Missing changelog |
iscai-msft
reviewed
May 18, 2021
...xtanalytics/src/main/java/com/azure/ai/textanalytics/AnalyzeHealthcareEntityAsyncClient.java
Show resolved
Hide resolved
maririos
reviewed
May 18, 2021
...azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTest.java
Outdated
Show resolved
Hide resolved
maririos
reviewed
May 18, 2021
...azure-ai-textanalytics/src/test/java/com/azure/ai/textanalytics/TextAnalyticsClientTest.java
Show resolved
Hide resolved
maririos
approved these changes
May 19, 2021
alzimmermsft
approved these changes
May 19, 2021
deyaaeldeen
reviewed
May 19, 2021
...i-textanalytics/src/main/java/com/azure/ai/textanalytics/models/AnalyzeSentimentOptions.java
Outdated
Show resolved
Hide resolved
maririos
reviewed
May 19, 2021
| @@ -43,8 +43,9 @@ public AnalyzeHealthcareEntitiesOptions setIncludeStatistics(boolean includeStat | |||
| /** | |||
| * Set the value of {@code disableServiceLogs}. | |||
| * | |||
| * @param disableServiceLogs If a boolean value was specified in the request this field will contain | |||
| * logging information about the document payload. | |||
| * @param disableServiceLogs The default value of this property is 'false'. This means, Text Analytics service logs | |||
There was a problem hiding this comment.
for healthcare, the default value is true. same for PII
There was a problem hiding this comment.
@deyaaeldeen hmm or maybe not?
There was a problem hiding this comment.
Looking at the swagger, only PiiTask sets this value to true... so better leave as you have it for now and we can start a conversation with the service team about it
There was a problem hiding this comment.
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Jan 4, 2023
Feature/cplat 2022 11 01 (Azure#21571) * add 2022-11-01 folder * update readme, update version reference * Added userData property for PUT Restore Point API Added user data property for PUT Restore Point API * Revert "Added userData property for PUT Restore Point API" This reverts commit 94c96d8ca8586b37a59083efd6357ccf2594dd61. * Reimage Support for Non-Ephemeral VMs (Azure#21090) * Reimage support for non-ephemeral VMs * small changes * small changes * resolving issues * pretty check * pretty install * remove package-lock * remove package-lock * Added userData property in Restore Point PUT API endpoint (Azure#21262) * Added userData property in Restore Point PUT Operation * Update based on review comment * Updated description Co-authored-by: Ashwani Tiwari <[email protected]> * Add OS Image profile to scheduled events profile and maxSurge in rolling upgrade policy in Microsoft.Compute (Azure#21253) * add reimage notification * update reimage notification, add max surge * fix grammar * Adding requireGuestProvisionSignal and constrainedMaximumCapacity mis… (Azure#21433) * Adding requireGuestProvisionSignal and constrainedMaximumCapacity missing properties * Moved the property at the end Co-authored-by: Avaiyang Garg <[email protected]> * Add serviceArtifactReference property (Azure#21607) * Add serviceArtifactReference property * Moved the property inside the virtualMachineScaleSet file * Minor change in example Co-authored-by: Avaiyang Garg <[email protected]> * add platformFaultDomain in instanceView (Azure#21605) * add platformFaultDomain in instanceView * change platformFaultDomain values * add APIVersionPattern Suppression (Azure#21675) Co-authored-by: Theodore Chang <[email protected]> * Adding imageDeprecationStatus properties to VirtualMachineImage response (Azure#21615) * Changes to virtualMachineImage.json to include ImageDeprecationStatus properties * Changes to example json * Fixed LintDiff errors * Addressed review comment * Introduce rollbackFailedInstancesOnPolicyBreach in VMSS RollingUpgradePolicy (Azure#21676) * add property in compute.json * add in 2022 file * add rollbackFailedInstancesOnPolicyBreach in examples * Revert "add property in compute.json" This reverts commit 15a1e10503cc4e34b0b69f351cc8f23339002360. * remove space Co-authored-by: Sachin Doddaiah Shylaja <[email protected]> Co-authored-by: Theodore Chang <[email protected]> * fix spellingCheck error, LintDiff error, model validation, and typo * fix modelValidation * model validation * update headers for examples * model validation errors * model validation * Revert "model validation" This reverts commit d3810a7866a9093b6ef75a57834e1aaeb4e139f3. * Revert "model validation errors" This reverts commit ba34d1b2af2bef58b60c16e9ed1cda00803a2ce0. * Revert "update headers for examples" This reverts commit 216b3dc1367655b8c7867a9d7a772fe7e2fa1583. * Revert "model validation" This reverts commit 285345656321e984bc99486a575e35a4d3359667. * Revert "fix modelValidation" This reverts commit a5fa156d42130566b827df88d6dea4ee591f4a6c. * Revert "fix spellingCheck error, LintDiff error, model validation, and typo" This reverts commit 9f60b71000be72bf4511feefcda0820b570345de. * fix spelling error CI, file name typo, Lint Diff Co-authored-by: Theodore Chang <[email protected]> Co-authored-by: Ashwani Tiwari <[email protected]> Co-authored-by: srcharug <[email protected]> Co-authored-by: csassasin <[email protected]> Co-authored-by: John Zhang <[email protected]> Co-authored-by: avaiyanggarg <[email protected]> Co-authored-by: Avaiyang Garg <[email protected]> Co-authored-by: parahluwalia <[email protected]> Co-authored-by: RajalakshmiSwaminathan <[email protected]> Co-authored-by: Sachin Doddaiah Shylaja <[email protected]> Co-authored-by: Sachin Doddaiah Shylaja <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: skip all files in the
implementationfolder because they are codegen files except theUtilityclass.API-view: https://apiview.dev/Assemblies/Review/329cfc783b474d97891a5349e705feb4?diffRevisionId=d72a86b3d386405fbc2cd3697bac29f3&doc=False&diffOnly=False