Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TA] Based on latest v3.1-preview.5 and added disableServiceLogs and AnalyzeSentimen action support #21262

Merged
merged 12 commits into from
May 19, 2021
Merged

[TA] Based on latest v3.1-preview.5 and added disableServiceLogs and AnalyzeSentimen action support #21262

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
bedeb4e
with regenerated code, preview.4 version works
mssfang May 5, 2021
21fce32
all implmentation changes
mssfang May 10, 2021
38f4f3d
working implementation
mssfang May 10, 2021
ca757c2
domainFilter
mssfang May 11, 2021
0b83d18
resolved SecurityManager issue
mssfang May 14, 2021
543b6b1
changelog and all test passed
mssfang May 18, 2021
ffda74b
StringIndexType in Changelog
mssfang May 18, 2021
6b21c70
address all feedbacks
mssfang May 19, 2021
0862969
enable healthcare tests
mssfang May 19, 2021
9f41cf6
remove unused import
mssfang May 19, 2021
815b3fd
CHANGELOG update
mssfang May 19, 2021
b88b1f8
disableLoggingOption docstring
mssfang May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...ics/src/main/java/com/azure/ai/textanalytics/models/AnalyzeHealthcareEntitiesOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ public AnalyzeHealthcareEntitiesOptions setIncludeStatistics(boolean includeStat
/**
* Set the value of {@code disableServiceLogs}.
*
* @param disableServiceLogs If a boolean value was specified in the request this field will contain
* logging information about the document payload.
* @param disableServiceLogs The default value of this property is 'false'. This means, Text Analytics service logs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for healthcare, the default value is true. same for PII

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deyaaeldeen hmm or maybe not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the swagger, only PiiTask sets this value to true... so better leave as you have it for now and we can start a conversation with the service team about it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR: https://github.com/Azure/azure-sdk-for-java/pull/21660/files

* your input text for 48 hours, solely to allow for troubleshooting issues. Setting this property to true,
* disables input logging and may limit our ability to investigate issues that occur.
*
* @return the {@link AnalyzeHealthcareEntitiesOptions} object itself.
*/
Expand Down
5 changes: 3 additions & 2 deletions ...extanalytics/src/main/java/com/azure/ai/textanalytics/models/AnalyzeSentimentOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ public AnalyzeSentimentOptions setIncludeStatistics(boolean includeStatistics) {
/**
* Set the value of {@code disableServiceLogs}.
*
* @param disableServiceLogs If a boolean value was specified in the request this field will contain
* logging information about the document payload.
* @param disableServiceLogs The default value of this property is 'false'. This means, Text Analytics service logs
* your input text for 48 hours, solely to allow for troubleshooting issues. Setting this property to true,
* disables input logging and may limit our ability to investigate issues that occur.
*
* @return the {@link AnalyzeSentimentOptions} object itself.
*/
Expand Down
5 changes: 3 additions & 2 deletions ...xtanalytics/src/main/java/com/azure/ai/textanalytics/models/ExtractKeyPhrasesOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ public ExtractKeyPhrasesOptions setIncludeStatistics(boolean includeStatistics)
/**
* Set the value of {@code disableServiceLogs}.
*
* @param disableServiceLogs If a boolean value was specified in the request this field will contain
* logging information about the document payload.
* @param disableServiceLogs The default value of this property is 'false'. This means, Text Analytics service logs
* your input text for 48 hours, solely to allow for troubleshooting issues. Setting this property to true,
* disables input logging and may limit our ability to investigate issues that occur.
*
* @return the {@link ExtractKeyPhrasesOptions} object itself.
*/
Expand Down
5 changes: 3 additions & 2 deletions ...xtanalytics/src/main/java/com/azure/ai/textanalytics/models/RecognizeEntitiesOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ public RecognizeEntitiesOptions setIncludeStatistics(boolean includeStatistics)
/**
* Set the value of {@code disableServiceLogs}.
*
* @param disableServiceLogs If a boolean value was specified in the request this field will contain
* logging information about the document payload.
* @param disableServiceLogs The default value of this property is 'false'. This means, Text Analytics service logs
* your input text for 48 hours, solely to allow for troubleshooting issues. Setting this property to true,
* disables input logging and may limit our ability to investigate issues that occur.
*
* @return the {@link RecognizeEntitiesOptions} object itself.
*/
Expand Down
5 changes: 3 additions & 2 deletions ...ytics/src/main/java/com/azure/ai/textanalytics/models/RecognizeLinkedEntitiesOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ public RecognizeLinkedEntitiesOptions setIncludeStatistics(boolean includeStatis
/**
* Set the value of {@code disableServiceLogs}.
*
* @param disableServiceLogs If a boolean value was specified in the request this field will contain
* logging information about the document payload.
* @param disableServiceLogs The default value of this property is 'false'. This means, Text Analytics service logs
* your input text for 48 hours, solely to allow for troubleshooting issues. Setting this property to true,
* disables input logging and may limit our ability to investigate issues that occur.
*
* @return the {@link RecognizeLinkedEntitiesOptions} object itself.
*/
Expand Down
5 changes: 3 additions & 2 deletions ...nalytics/src/main/java/com/azure/ai/textanalytics/models/RecognizePiiEntitiesOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,9 @@ public RecognizePiiEntitiesOptions setIncludeStatistics(boolean includeStatistic
/**
* Set the value of {@code disableServiceLogs}.
*
* @param disableServiceLogs If a boolean value was specified in the request this field will contain
* logging information about the document payload.
* @param disableServiceLogs The default value of this property is 'false'. This means, Text Analytics service logs
* your input text for 48 hours, solely to allow for troubleshooting issues. Setting this property to true,
* disables input logging and may limit our ability to investigate issues that occur.
*
* @return the {@link RecognizePiiEntitiesOptions} object itself.
*/
Expand Down
9 changes: 6 additions & 3 deletions ...nalytics/src/main/java/com/azure/ai/textanalytics/models/TextAnalyticsRequestOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,9 @@ public TextAnalyticsRequestOptions setIncludeStatistics(boolean includeStatistic
/**
* Get the value of {@code disableServiceLogs}.
*
* @return The value of {@code disableServiceLogs}.
* @return The value of {@code disableServiceLogs}. The default value of this property is 'false'. This means,
* Text Analytics service logs your input text for 48 hours, solely to allow for troubleshooting issues. Setting
* this property to true, disables input logging and may limit our ability to investigate issues that occur.
*/
public boolean isServiceLogsDisabled() {
return disableServiceLogs;
Expand All @@ -72,8 +74,9 @@ public boolean isServiceLogsDisabled() {
/**
* Set the value of {@code disableServiceLogs}.
*
* @param disableServiceLogs If a boolean value was specified in the request this field will contain
* logging information about the document payload.
* @param disableServiceLogs The default value of this property is 'false'. This means, Text Analytics service logs
* your input text for 48 hours, solely to allow for troubleshooting issues. Setting this property to true,
* disables input logging and may limit our ability to investigate issues that occur.
*
* @return the {@link TextAnalyticsRequestOptions} object itself.
*/
Expand Down