Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Respect env variables listed in the guidelines #3057

Closed
ramya-rao-a opened this issue May 21, 2019 · 5 comments
Closed

[Service Bus] Respect env variables listed in the guidelines #3057

ramya-rao-a opened this issue May 21, 2019 · 5 comments
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus

Comments

@ramya-rao-a
Copy link
Contributor

The section on environment variables in the guidelines require us to load the relevant settings from the below environment variables, but Service Bus doesnt do so today.

image

@bterlson Would you suggest that this be done by the library independent of the efforts for the common configuration service?

@ramya-rao-a ramya-rao-a added Client This issue points to a problem in the data-plane of the library. Service Bus labels May 21, 2019
@ramya-rao-a ramya-rao-a added this to the Backlog milestone Apr 10, 2020
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2020] June May 5, 2020
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, [2020] June May 8, 2020
@xirzec xirzec modified the milestones: [2020] June, [2020] July Jun 8, 2020
@ramya-rao-a
Copy link
Contributor Author

Updated link: https://github.com/Azure/azure-sdk/blob/master/_includes/tables/environment_variables.md

The ones under Identity section is handled by the @azure/identity package.
AZURE_LOG_LEVEL is already taken care of in the logger package.

@xirzec, Can AZURE_TRACING_DISABLED be handled in a central location i.e. in the core-tracing package?

#5696 tracks the rest for SDKS for http based services

The ones applicable to Event Hubs & Service Bus are the proxy related env vars only.
But, one needs to choose a WebSocket implementation, which takes the proxy related info when wanting to work with proxy. So, the Event Hubs & the Service Bus packages cannot implicitly make use of the environment variables to work with proxy.

@xirzec
Copy link
Member

xirzec commented Jul 15, 2020

I'm actually curious what we should do in the case that AZURE_TRACING_DISABLED is set but the user passes us a valid tracer and parent span.

Certainly we could make a helper for looking at the variable and put that in core-tracing, though I'm less certain about the best way to implement since today we use a NoopSpans in the null case. Maybe if that variable is set, we simply throw if you try to set a global tracer?

@ramya-rao-a
Copy link
Contributor Author

Maybe if that variable is set, we simply throw if you try to set a global tracer?

I should be able to tweak the env variable and disable tracing without having to change my code.
So, my vote is to not throw and use the no-op tracer

@ramya-rao-a
Copy link
Contributor Author

Logged #10205 to track the work on AZURE_TRACING_DISABLED

@ramya-rao-a
Copy link
Contributor Author

Closing as no further work is pending here

@xirzec xirzec removed this from the Backlog milestone May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library. Event Hubs Service Bus
Projects
None yet
Development

No branches or pull requests

3 participants