Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure.Core & Azure.Identity needs to be updated to support env vars #5696

Closed
1 of 2 tasks
joshfree opened this issue Oct 21, 2019 · 6 comments
Closed
1 of 2 tasks

Azure.Core & Azure.Identity needs to be updated to support env vars #5696

joshfree opened this issue Oct 21, 2019 · 6 comments
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.

Comments

@joshfree
Copy link
Member

joshfree commented Oct 21, 2019

The environment variables identified in https://github.com/Azure/azure-sdk/blob/master/_includes/tables/environment_variables.md such as

Environment Variable Purpose
Proxy Settings
HTTP_PROXY Proxy for HTTP connections
HTTPS_PROXY Proxy for HTTPS connections
NO_PROXY Hosts which must not use a proxy
Identity
MSI_ENDPOINT Azure AD MSI Credentials
MSI_SECRET Azure AD MSI Credentials
AZURE_SUBSCRIPTION_ID Azure subscription
AZURE_USERNAME Azure username for U/P Auth
AZURE_PASSWORD Azure password for U/P Auth
AZURE_CLIENT_CERTIFICATE_PATH Azure Active Directory
AZURE_CLIENT_ID Azure Active Directory
AZURE_CLIENT_SECRET Azure Active Directory
AZURE_TENANT_ID Azure Active Directory
AZURE_RESOURCE_GROUP Azure Resource Group
AZURE_CLOUD Name of the sovereign cloud
Pipeline Configuration
AZURE_TELEMETRY_DISABLED Disables telemetry
AZURE_LOG_LEVEL Enable logging by setting a log level.
AZURE_TRACING_DISABLED Disables tracing
AZURE_AUTHORITY_HOST Azure Active Directory
  • ManagedIdentityCredential - AZURE_CLIENT_ID

  • TokenCredentialOptions - AZURE_AUTHORITY_HOST

need to be reviewed, supported, and tested for our Azure.Core and Azure.Identity. There are at least some of these not currently properly supported, such as AZURE_CLOUD for example.

@ramya-rao-a
Copy link
Contributor

Looks like #7069 will handle the NO_PROXY env var.
#10205 is tracking AZURE_TRACING_DISABLED

Do we know how we expect Azure Core to respect the below?
I would expect this to be handled by individual libraries.

  • AZURE_SUBSCRIPTION_ID
  • AZURE_RESOURCE_GROUP
  • AZURE_CLOUD
  • AZURE_AUTHORITY_HOST

For AZURE_TELEMETRY_DISABLED, am guessing we disable the user agent policy?

cc @xirzec

@sadasant
Copy link
Contributor

Question,

Is AZURE_CLOUD the same as AZURE_AUTHORITY_HOST?

@sadasant
Copy link
Contributor

To update this with an answer to my question, I asked my question above to @schaabs over a private channel and his response was more or less the following:

AZURE_CLOUD impacts a bunch of endpoints such as the Arm endpoint, the default authority and others [...] it requires a deeper design that we haven't really gotten any guidance from the archboard on this yet

@Marcus-James-Adams
Copy link

Is there an update as to when support for AZURE_SUBSCRIPTION_ID will be supported?

@xirzec
Copy link
Member

xirzec commented Aug 29, 2022

Is there an update as to when support for AZURE_SUBSCRIPTION_ID will be supported?

@Marcus-James-Adams can you help me to understand where you would like to use AZURE_SUBSCRIPTION_ID? Are you trying to avoid having to retrieve the value from the environment manually when using a ResourceManagementClient?

It's not clear to me how Core / Identity can make use of this information at the moment.

Copy link

Hi @joshfree, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Azure.Identity Client This issue points to a problem in the data-plane of the library. feature-request This issue requires a new behavior in the product in order be resolved.
Projects
None yet
Development

No branches or pull requests

7 participants