Respect the AZURE_TRACING_DISABLED env variable #10205
Assignees
Labels
Azure.Core
Client
This issue points to a problem in the data-plane of the library.
feature-request
This issue requires a new behavior in the product in order be resolved.
Milestone
Comments
ramya-rao-a
added
Client
This was referenced Jul 23, 2020
maorleger
added a commit
that referenced
this issue
Jul 15, 2021
## What - Remove `setTracer` - Remove `NoOpTracer` and `NoOpSpan` - Use Otel's APIs where possible (like when creating a no-op) - Respect AZURE_TRACING_DISABLED environment variable - Include test support for tracing utilizing OTel's trace API - Avoid injecting invalid `tracerparent` header fields ## Why - `setTracer` was added before OTel had their own implementation of a global tracer provider. For consistency with other libraries we should use the global tracer that was registered. It also leaves us out of the business of maintaining caches, global tracers, and other annoying things. - These are no longer needed, since OTel has a recommended way to wrap a span in a NoOp. And, if no tracer provider was registered, a non-recording tracer (NoOp) will be created. All managed by OTel - Finally, AZURE_TRACING_DISABLED is one of the env vars our guidelines say we should support Resolves #16088 Resolves #15730 Resolves #10205
deyaaeldeen
pushed a commit
that referenced
this issue
Jul 26, 2021
## What - Remove `setTracer` - Remove `NoOpTracer` and `NoOpSpan` - Use Otel's APIs where possible (like when creating a no-op) - Respect AZURE_TRACING_DISABLED environment variable - Include test support for tracing utilizing OTel's trace API - Avoid injecting invalid `tracerparent` header fields ## Why - `setTracer` was added before OTel had their own implementation of a global tracer provider. For consistency with other libraries we should use the global tracer that was registered. It also leaves us out of the business of maintaining caches, global tracers, and other annoying things. - These are no longer needed, since OTel has a recommended way to wrap a span in a NoOp. And, if no tracer provider was registered, a non-recording tracer (NoOp) will be created. All managed by OTel - Finally, AZURE_TRACING_DISABLED is one of the env vars our guidelines say we should support Resolves #16088 Resolves #15730 Resolves #10205
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Our guidelines on env variables list that
AZURE_TRACING_DISABLEDenv variable should be respected.One option is to use the No-op tracer when this env variable is set.
The text was updated successfully, but these errors were encountered: